tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-28 16:24:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Form: Add some todos regarding the handling of "api targets"

Browse Source 
I've added them only for our future "migration" to `ipl\html\Form`.
We MUST NOT migrate this flawed handling of API targets.
This commit is contained in:
Johannes Meyer 2021-02-18 12:16:43 +01:00
parent 7aacbd4db8
commit 16be5f9572
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
library/Icinga/Web/Form.php
View File

@ -737,6 +737,7 @@ class Form extends Zend_Form
/** /**
* Get whether the form is an API target * Get whether the form is an API target
* *
* @todo This should probably only return true if the request is also an api request
* @return bool * @return bool
*/ */
public function getIsApiTarget() public function getIsApiTarget()
@ -1157,6 +1158,7 @@ class Form extends Zend_Form
$formData = $this->getRequestData(); $formData = $this->getRequestData();
if ($this->getIsApiTarget() if ($this->getIsApiTarget()
// TODO: Very very bad, wasSent() must not be bypassed if it's only an api request but not an qpi target
|| $this->getRequest()->isApiRequest() || $this->getRequest()->isApiRequest()
|| $this->getUidDisabled() || $this->getUidDisabled()
|| $this->wasSent($formData) || $this->wasSent($formData)
@ -1170,6 +1172,7 @@ class Form extends Zend_Form
&& (($this->onSuccess !== null && false !== call_user_func($this->onSuccess, $this)) && (($this->onSuccess !== null && false !== call_user_func($this->onSuccess, $this))
|| ($this->onSuccess === null && false !== $this->onSuccess())) || ($this->onSuccess === null && false !== $this->onSuccess()))
) { ) {
// TODO: Still bad. An api target must not behave as one if it's not an api request
if ($this->getIsApiTarget() || $this->getRequest()->isApiRequest()) { if ($this->getIsApiTarget() || $this->getRequest()->isApiRequest()) {
// API targets and API requests will never redirect but immediately respond w/ JSON-encoded // API targets and API requests will never redirect but immediately respond w/ JSON-encoded
// notifications // notifications
@ -1189,6 +1192,7 @@ class Form extends Zend_Form
} else { } else {
$this->getView()->layout()->redirectUrl = $this->getRedirectUrl()->getAbsoluteUrl(); $this->getView()->layout()->redirectUrl = $this->getRedirectUrl()->getAbsoluteUrl();
} }
// TODO: Still bad. An api target must not behave as one if it's not an api request
} elseif ($this->getIsApiTarget() || $this->getRequest()->isApiRequest()) { } elseif ($this->getIsApiTarget() || $this->getRequest()->isApiRequest()) {
$this->getResponse()->json()->setFailData($this->getMessages())->sendResponse(); $this->getResponse()->json()->setFailData($this->getMessages())->sendResponse();
} }