Improve .ini file formatting

End every file with a newline, and only display 1 empty line between each section, to improve readabillity.

fixes #8706

library/Icinga/File/Ini/IniEditor.php

@@ -62,7 +62,7 @@ class IniEditor
         $this->commentIndentation = array_key_exists('commentIndentation', $options)
             ? $options['commentIndentation'] : 43;
         $this->sectionSeparators = array_key_exists('sectionSeparators', $options)
-            ? $options['sectionSeparators'] : 2;
+            ? $options['sectionSeparators'] : 1;
     }
 
     /**
@@ -323,6 +323,12 @@ class IniEditor
     private function cleanUpWhitespaces()
     {
         $i = count($this->text) - 1;
+
+        // remove all trailing whitespaces
+        while ($i > 0 && preg_match('/^\s*$/', $this->text[$i]) === 1) {
+            $this->deleteLine($i);
+            $i--;
+        }
         for (; $i > 0; $i--) {
             $line = $this->text[$i];
             if ($this->isSectionDeclaration($line) && $i > 0) {
@@ -351,6 +357,8 @@ class IniEditor
                 }
             }
         }
+        // always end file with a linebreak
+        $this->insertAtLine(count($this->text) + 1, "");
     }
 
     /**

modules/monitoring/application/views/scripts/services/show.phtml

@@ -106,8 +106,6 @@
                 ); ?>
             <?php endif ?>
 
-            <?php
-            ?>
             <?php if ($unackCount > 0): ?>
                 <br>
                 <?= $this->qlink(