tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-25 14:54:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

RoleForm: Use an <h3> for set headers, not legend

Browse Source 
legend and `overflow:hidden` are bugged in safari..
This commit is contained in:
Johannes Meyer 2019-07-24 15:01:52 +02:00
parent 37387b603f
commit 1b4b42a465
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
application/forms/Security/RoleForm.php
View File

@ -174,9 +174,21 @@ class RoleForm extends RepositoryForm
foreach ($this->providedPermissions as $moduleName => $permissionList) { foreach ($this->providedPermissions as $moduleName => $permissionList) {
$this->sortPermissions($permissionList); $this->sortPermissions($permissionList);
$elements = ['permission_header']; $elements = [$moduleName . '_header'];
$this->addElement(
'note',
$moduleName . '_header',
[
'decorators' => ['ViewHelper'],
'value' => '<h3>' . ($moduleName !== 'application'
? sprintf($this->translate('Module: %s'), $moduleName)
: 'Icinga Web 2') . '</h3>'
]
);
$elements[] = 'permission_header';
$this->addElement('note', 'permission_header', [ $this->addElement('note', 'permission_header', [
'value' => '<h3>' . $this->translate('Permissions') . '</h3>' 'value' => '<h4>' . $this->translate('Permissions') . '</h4>'
]); ]);
$hasFullPerm = false; $hasFullPerm = false;
@ -205,7 +217,7 @@ class RoleForm extends RepositoryForm
if (isset($this->providedRestrictions[$moduleName])) { if (isset($this->providedRestrictions[$moduleName])) {
$elements[] = 'restriction_header'; $elements[] = 'restriction_header';
$this->addElement('note', 'restriction_header', [ $this->addElement('note', 'restriction_header', [
'value' => '<h3>' . $this->translate('Restrictions') . '</h3>' 'value' => '<h4>' . $this->translate('Restrictions') . '</h4>'
]); ]);
foreach ($this->providedRestrictions[$moduleName] as $name => $spec) { foreach ($this->providedRestrictions[$moduleName] as $name => $spec) {
@ -225,12 +237,13 @@ class RoleForm extends RepositoryForm
} }
$this->addDisplayGroup($elements, $moduleName . '_elements', [ $this->addDisplayGroup($elements, $moduleName . '_elements', [
'legend' => $moduleName !== 'application'
? sprintf($this->translate('Module: %s'), $moduleName)
: 'Icinga Web 2',
'decorators' => [ 'decorators' => [
'FormElements', 'FormElements',
['Fieldset', ['class' => 'collapsible', 'data-toggle-element' => 'legend']] ['Fieldset', [
'class' => 'collapsible',
'data-toggle-element' => 'h3',
'data-visible-height' => 64
]]
] ]
]); ]);
} }