config/module: Show library dependencies and unmet ones

application/controllers/ConfigController.php

@@ -138,6 +138,8 @@ class ConfigController extends Controller
             }
 
             $this->view->module = $module;
+            $this->view->libraries = $app->getLibraries();
+            $this->view->moduleManager = $manager;
             $this->view->toggleForm = $toggleForm;
             $this->view->title = $module->getName();
             $this->view->tabs = $module->getConfigTabs()->activate('info');

application/views/scripts/config/module.phtml

@@ -6,9 +6,11 @@
     <?= $this->translate('There is no such module installed.') ?>
   <?php return; endif ?>
   <?php
-    $dependencies = $module->getDependencies();
+    $requiredMods = $module->getRequiredModules();
+    $requiredLibs = $module->getRequiredLibraries();
     $restrictions = $module->getProvidedRestrictions();
     $permissions = $module->getProvidedPermissions();
+    $unmetDependencies = $moduleManager->hasUnmetDependencies($module->getName());
     $state = $moduleData->enabled ? ($moduleData->loaded ? 'enabled' : 'failed') : 'disabled'
   ?>
   <table class="name-value-table">
@@ -20,9 +22,13 @@
       <th><?= $this->translate('State') ?></th>
       <td>
         <?= $state ?>
-        <?php if (isset($this->toggleForm)): ?>
+      <?php if (isset($this->toggleForm)): ?>
+        <?php if ($moduleData->enabled || ! $unmetDependencies): ?>
           <?= $this->toggleForm ?>
+        <?php else: ?>
+          <?= $this->icon('attention-alt', $this->translate('Module can\'t be enabled due to unmet dependencies')) ?>
         <?php endif ?>
+      <?php endif ?>
       </td>
     <tr>
       <th><?= $this->escape($this->translate('Version')) ?></th>
@@ -43,13 +49,58 @@
     </tr>
     <tr>
       <th><?= $this->escape($this->translate('Dependencies')) ?></th>
-      <td>
+      <td class="module-dependencies">
-        <?php
+      <?php if (empty($requiredLibs) && empty($requiredMods)): ?>
-          if (empty($dependencies)):
+          <?= $this->translate('This module has no dependencies') ?>
-            echo $this->translate('This module has no dependencies');
+      <?php else: ?>
-          else: foreach ($dependencies as $name => $versionString): ?>
+        <?php if ($unmetDependencies): ?>
-            <strong><?= $this->escape($name) ?></strong><?php if ($versionString !== true): ?>: <?= $this->escape($versionString) ?><?php endif ?><br />
+          <strong class="unmet-dependencies">
-        <?php endforeach; endif ?>
+            <?= $this->translate('Unmet dependencies found! Module can\'t be enabled unless all dependencies are met.') ?>
+          </strong>
+        <?php endif ?>
+        <?php if (! empty($requiredLibs)): ?>
+          <table class="name-value-table">
+              <caption><?= $this->translate('Libraries') ?></caption>
+          <?php foreach ($requiredLibs as $libraryName => $versionString): ?>
+              <tr>
+                  <th><?= $this->escape($libraryName) ?></th>
+                  <td>
+                  <?php if ($libraries->has($libraryName, $versionString === true ? null : $versionString)): ?>
+                      <?= $versionString === true ? '*' : $this->escape($versionString) ?>
+                  <?php else: ?>
+                      <span class="missing"><?= $versionString === true ? '*' : $this->escape($versionString) ?></span>
+                    <?php if (($library = $libraries->get($libraryName)) !== null): ?>
+                      (<?= $library->getVersion() ?>)
+                    <?php endif ?>
+                  <?php endif ?>
+                  </td>
+              </tr>
+          <?php endforeach ?>
+          </table>
+        <?php endif ?>
+        <?php if (! empty($requiredMods)): ?>
+          <table class="name-value-table">
+              <caption><?= $this->translate('Modules') ?></caption>
+          <?php foreach ($requiredMods as $moduleName => $versionString): ?>
+              <tr>
+                  <th><?= $this->escape($moduleName) ?></th>
+                  <td>
+                  <?php if ($moduleManager->has($moduleName, $versionString === true ? null : $versionString)): ?>
+                      <?= $versionString === true ? '*' : $this->escape($versionString) ?>
+                  <?php else: ?>
+                      <span class="missing"><?= $versionString === true ? '*' : $this->escape($versionString) ?></span>
+                    <?php if (! $moduleManager->hasInstalled($moduleName)): ?>
+                      (<?= $this->translate('not installed') ?>)
+                    <?php else: ?>
+                      (<?= $moduleManager->getModule($moduleName, false)->getVersion() ?><?= $moduleManager->hasEnabled($moduleName) ? '' : ', ' . $this->translate('disabled') ?>)
+                    <?php endif ?>
+                  <?php endif ?>
+                  </td>
+              </tr>
+          <?php endforeach ?>
+          </table>
+        <?php endif ?>
+      <?php endif ?>
       </td>
     </tr>
     <?php if (! empty($permissions)): ?>

public/css/icinga/main.less

@@ -178,6 +178,12 @@ a:hover > .icon-cancel {
   width: 100%;
 }
 
+.name-value-table > caption {
+  margin-top: .5em;
+  text-align: left;
+  font-weight: bold;
+}
+
 .name-value-table > tbody > tr > th {
   color: @text-color-light;
   // Reset default font-weight
@@ -350,4 +356,30 @@ a:hover > .icon-cancel {
       padding-right: 0;
     }
   }
+}
+
+.module-dependencies {
+  .unmet-dependencies {
+    background-color: @color-warning;
+    color: @text-color-on-icinga-blue;
+    padding: .25em .5em;
+    margin-left: -.5em;
+  }
+
+  .name-value-table {
+    > caption {
+      font-weight: normal;
+      color: @text-color-light;
+    }
+
+    > tbody > tr > th {
+      font-weight: bold;
+      color: @text-color;
+    }
+
+    .missing {
+      color: @color-critical;
+      font-weight: bold;
+    }
+  }
 }