Allow install steps to return no summary

refs #7163

application/views/scripts/form/setup-summary.phtml

@@ -13,9 +13,11 @@ use Icinga\Web\Wizard;
 ); ?></p>
 <div class="summary">
 <?php foreach ($form->getSummary() as $pageHtml): ?>
+ <?php if ($pageHtml): ?>
   <div class="page">
     <?= $pageHtml; ?>
   </div>
+ <?php endif ?>
 <?php endforeach ?>
 </div>
 <form id="<?= $form->getName(); ?>" name="<?= $form->getName(); ?>" enctype="<?= $form->getEncType(); ?>" method="<?= $form->getMethod(); ?>" action="<?= $form->getAction(); ?>">

application/views/scripts/setup/parts/install.phtml

@@ -2,7 +2,7 @@
   <div class="report">
   <?php $firstLine = true; ?>
   <?php foreach ($report as $entry): ?>
-    <?php if ($entry !== ''): ?>
+    <?php if ($entry): ?>
       <?php if (false === $firstLine): ?>
         <div class="line-separator"></div>
       <?php endif ?>

library/Icinga/Installation/DatabaseStep.php

@@ -235,8 +235,6 @@ class DatabaseStep extends Step
             return '<p>' . join('</p><p>', $this->messages) . '</p>'
                 . '<p class="error">' . $message . '</p><p>' . $this->error->getMessage() . '</p>';
         }
-
-        return '';
     }
 
     protected function log()

library/Icinga/Installation/GeneralConfigStep.php

@@ -128,7 +128,5 @@ class GeneralConfigStep extends Step
             return '<p class="error">' . sprintf($message, Config::resolvePath('config.ini')) . '</p>'
                 . '<p>' . $this->error->getMessage() . '</p>';
         }
-
-        return '';
     }
 }

library/Icinga/Installation/ResourceStep.php

@@ -146,7 +146,5 @@ class ResourceStep extends Step
             return '<p class="error">' . sprintf($message, Config::resolvePath('resources.ini')) . '</p>'
                 . '<p>' . $this->error->getMessage() . '</p>';
         }
-
-        return '';
     }
 }