tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-27 07:44:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid local variable name `self' in events.js

Browse Source 
refs #10703
This commit is contained in:
Alexander A. Klimov 2016-09-01 16:13:38 +02:00
parent 4e2c626ae0
commit 3c43d38171
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
public/js/icinga/events.js
View File

@ -33,8 +33,8 @@
// TODO: What's this? // TODO: What's this?
applyHandlers: function (event) { applyHandlers: function (event) {
var $target = $(event.target); var $target = $(event.target);
var self = event.data.self; var _this = event.data.self;
var icinga = self.icinga; var icinga = _this.icinga;
if (! icinga) { if (! icinga) {
// Attempt to catch a rare error, race condition, whatever // Attempt to catch a rare error, race condition, whatever
@ -42,7 +42,7 @@
return; return;
} }
if (self.initializeModules) { if (_this.initializeModules) {
var loaded = false; var loaded = false;
var moduleName = $target.data('icingaModule'); var moduleName = $target.data('icingaModule');
if (moduleName) { if (moduleName) {
@ -63,7 +63,7 @@
// so we need to ensure that it is called the first time they are // so we need to ensure that it is called the first time they are
// initialized // initialized
event.stopImmediatePropagation(); event.stopImmediatePropagation();
self.initializeModules = false; _this.initializeModules = false;
var $container = $target.closest('.container'); var $container = $target.closest('.container');
if (! $container.length) { if (! $container.length) {
@ -79,7 +79,7 @@
return false; return false;
} }
} else { } else {
self.initializeModules = true; _this.initializeModules = true;
} }
$('.dashboard > div', $target).each(function(idx, el) { $('.dashboard > div', $target).each(function(idx, el) {
@ -93,7 +93,7 @@
var $searchField = $('#menu input.search', $target); var $searchField = $('#menu input.search', $target);
// Remember initial search field value if any // Remember initial search field value if any
if ($searchField.length && $searchField.val().length) { if ($searchField.length && $searchField.val().length) {
self.searchValue = $searchField.val(); _this.searchValue = $searchField.val();
} }
}, },
@ -190,12 +190,12 @@
}, },
autoSubmitSearch: function(event) { autoSubmitSearch: function(event) {
var self = event.data.self; var _this = event.data.self;
if ($('#menu input.search').val() === self.searchValue) { if ($('#menu input.search').val() === _this.searchValue) {
return; return;
} }
self.searchValue = $('#menu input.search').val(); _this.searchValue = $('#menu input.search').val();
return self.autoSubmitForm(event); return _this.autoSubmitForm(event);
}, },
rememberSubmitButton: function(e) { rememberSubmitButton: function(e) {
@ -212,8 +212,8 @@
* *
*/ */
submitForm: function (event, autosubmit) { submitForm: function (event, autosubmit) {
var self = event.data.self; var _this = event.data.self;
var icinga = self.icinga; var icinga = _this.icinga;
// .closest is not required unless subelements to trigger this // .closest is not required unless subelements to trigger this
var $form = $(event.currentTarget).closest('form'); var $form = $(event.currentTarget).closest('form');
var url = $form.attr('action'); var url = $form.attr('action');
@ -277,9 +277,9 @@
$button.addClass('active'); $button.addClass('active');
} }
$target = self.getLinkTargetFor($button); $target = _this.getLinkTargetFor($button);
} else { } else {
$target = self.getLinkTargetFor($form); $target = _this.getLinkTargetFor($form);
} }
if (! url) { if (! url) {
@ -427,8 +427,8 @@
* Someone clicked a link or tr[href] * Someone clicked a link or tr[href]
*/ */
linkClicked: function (event) { linkClicked: function (event) {
var self = event.data.self; var _this = event.data.self;
var icinga = self.icinga; var icinga = _this.icinga;
var $a = $(this); var $a = $(this);
var $eventTarget = $(event.target); var $eventTarget = $(event.target);
var href = $a.attr('href'); var href = $a.attr('href');
@ -512,7 +512,7 @@
} }
return false; return false;
} }
$target = self.getLinkTargetFor($a); $target = _this.getLinkTargetFor($a);
formerUrl = $target.data('icingaUrl'); formerUrl = $target.data('icingaUrl');
if (typeof formerUrl !== 'undefined' && formerUrl.split(/#/)[0] === href.split(/#/)[0]) { if (typeof formerUrl !== 'undefined' && formerUrl.split(/#/)[0] === href.split(/#/)[0]) {
@ -524,7 +524,7 @@
return false; return false;
} }
} else { } else {
$target = self.getLinkTargetFor($a); $target = _this.getLinkTargetFor($a);
} }
// Load link URL // Load link URL