tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix TacticalController if/else complexity

This commit is contained in:
Eric Lippmann 2017-11-22 11:10:56 +01:00
parent fbeafdc8b4
commit 3db9a1d77f
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/monitoring/application/controllers/TacticalController.php
View File

@ -62,14 +62,10 @@ class TacticalController extends Controller
->addSlice($summary->hosts_unreachable_unhandled, array('class' => 'slice-state-unreachable'))
->addSlice($summary->hosts_pending, array('class' => 'slice-state-pending'))
->addSlice($summary->hosts_not_checked, array('class' => 'slice-state-not-checked'));
if ($summary->hosts_down_unhandled > 1) {
if ($summary->hosts_down_unhandled > 0) {
$hostSummaryChart
->setLabelBig($summary->hosts_down_unhandled)
->setLabelSmall($this->translate('hosts down'));
} elseif ($summary->hosts_down_unhandled === 1) {
$hostSummaryChart
->setLabelBig($summary->hosts_down_unhandled)
->setLabelSmall($this->translate('host down'));
}
$serviceSummaryChart = new Donut();
@ -83,14 +79,10 @@ class TacticalController extends Controller
->addSlice($summary->services_unknown_unhandled, array('class' => 'slice-state-unknown'))
->addSlice($summary->services_pending, array('class' => 'slice-state-pending'))
->addSlice($summary->services_not_checked, array('class' => 'slice-state-not-checked'));
if ($summary->services_critical_unhandled > 1) {
if ($summary->services_critical_unhandled > 0) {
$serviceSummaryChart
->setLabelBig($summary->services_critical_unhandled)
->setLabelSmall($this->translate('services critical'));
} elseif ($summary->services_critical_unhandled === 1) {
$hostSummaryChart
->setLabelBig($summary->hosts_down_unhandled)
->setLabelSmall($this->translate('service critical'));
}
$this->view->hostStatusSummaryChart = $hostSummaryChart