tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-27 15:54:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Web\UrlTest: test should use %20 instead of +

Browse Source 
We MUST use rawurlencode everywhere to avoid potential conflicts with
URLs created on JS side.

refs #6604
This commit is contained in:
Thomas Gelf 2014-08-19 12:39:53 +02:00
parent db3ef8fbd0
commit 3f65f3447d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/php/library/Icinga/Web/UrlTest.php
View File

@ -21,7 +21,7 @@ class UrlTest extends BaseTestCase
$url = Url::fromRequest(); $url = Url::fromRequest();
$this->assertEquals( $this->assertEquals(
'/path/to/my/test/url.html?param1=value1&param2=value2', '/path/to/my/test/url.html?param1=value1&param2=value2',
$url->getAbsoluteUrl(), $url->getAbsoluteUrl('&'),
'Url::fromRequest does not reassemble the correct url from the global request' 'Url::fromRequest does not reassemble the correct url from the global request'
); );
} }
@ -119,7 +119,7 @@ class UrlTest extends BaseTestCase
*/ */
public function testWhetherFromPathProperlyRecognizesAndDecodesQueryParameters() public function testWhetherFromPathProperlyRecognizesAndDecodesQueryParameters()
{ {
$url = Url::fromPath('/my/test/url.html?param1=%25arg1&param2=arg+2' $url = Url::fromPath('/my/test/url.html?param1=%25arg1&param2=arg%202'
. '&param3[]=1&param3[]=2&param3[]=3&param4[key1]=val1&param4[key2]=val2'); . '&param3[]=1&param3[]=2&param3[]=3&param4[key1]=val1&param4[key2]=val2');
$this->assertEquals( $this->assertEquals(