From 45fd1b78f14d72fde16ce8cfa20a195478bdb718 Mon Sep 17 00:00:00 2001 From: Johannes Meyer Date: Wed, 27 May 2015 08:55:14 +0200 Subject: [PATCH] UserGroupController: Properly handle errors when fetching memberships refs #8826 --- application/controllers/UserController.php | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/application/controllers/UserController.php b/application/controllers/UserController.php index fc13c5455..c96e94dab 100644 --- a/application/controllers/UserController.php +++ b/application/controllers/UserController.php @@ -250,11 +250,19 @@ class UserController extends AuthBackendController { $groups = array(); foreach ($this->loadUserGroupBackends() as $backend) { - foreach ($backend->getMemberships($user) as $groupName) { - $groups[] = (object) array( - 'group_name' => $groupName, - 'backend' => $backend - ); + try { + foreach ($backend->getMemberships($user) as $groupName) { + $groups[] = (object) array( + 'group_name' => $groupName, + 'backend' => $backend + ); + } + } catch (Exception $e) { + Logger::error($e); + Notification::warning(sprintf( + $this->translate('Failed to fetch memberships from backend %s. Please check your log'), + $backend->getName() + )); } }