From 4ab79a67584c64d430cfe8fa5db07e790dabb7c7 Mon Sep 17 00:00:00 2001 From: Sukhwinder Dhillon Date: Mon, 30 May 2022 12:21:51 +0200 Subject: [PATCH] DataView: Remove not in use method `applyUrlFilter()` --- doc/80-Upgrading.md | 1 + .../library/Monitoring/DataView/DataView.php | 20 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/doc/80-Upgrading.md b/doc/80-Upgrading.md index 28dcb085b..c7005abe5 100644 --- a/doc/80-Upgrading.md +++ b/doc/80-Upgrading.md @@ -44,6 +44,7 @@ v2.6 to v2.8 requires to follow the instructions for v2.7 too. + `DbConnection::getConnection()`: Use `Connection::getDbAdapter()` instead. + `DbQuery::renderFilter()`: Use `DbConnection::renderFilter()` instead. + `DbQuery::whereToSql()`: Use `DbConnection::renderFilter()` instead. ++ `DataView::applyUrlFilter()`: Not in use. **Classes:** + `Icinga\Util\String`: Use `Icinga\Util\StringHelper` instead. diff --git a/modules/monitoring/library/Monitoring/DataView/DataView.php b/modules/monitoring/library/Monitoring/DataView/DataView.php index 42ec1e75e..4d9eacdb4 100644 --- a/modules/monitoring/library/Monitoring/DataView/DataView.php +++ b/modules/monitoring/library/Monitoring/DataView/DataView.php @@ -135,26 +135,6 @@ abstract class DataView implements QueryInterface, SortRules, FilterColumns, Ite return $columns; } - // TODO: This is not the right place for this, move it away - protected function applyUrlFilter($request = null) - { - $url = Url::fromRequest(); - - $limit = $url->shift('limit'); - $sort = $url->shift('sort'); - $dir = $url->shift('dir'); - $page = $url->shift('page'); - $format = $url->shift('format'); - $view = $url->shift('showCompact'); - $view = $url->shift('backend'); - foreach ($url->getParams() as $k => $v) { - $this->where($k, $v); - } - if ($sort) { - $this->order($sort, $dir); - } - } - /** * Create view from params *