tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

js: Don't serve scripts utilizing ECMA2016+ features 

i.e. library javascript assets
This commit is contained in:
Johannes Meyer 2021-02-22 16:01:42 +01:00
parent 64d1574972
commit 4d4f5b3a69
4 changed files with 46 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
library/Icinga/Application/webrouter.php
View File

@ -63,11 +63,13 @@ if (in_array($path, $special)) {
exit;
case 'js/icinga.dev.js':
JavaScript::send();
$forIe11 = (bool) preg_match('/Trident\/7.0;.*rv:11/', $_SERVER['HTTP_USER_AGENT']);
JavaScript::send(false, $forIe11);
exit;
case 'js/icinga.min.js':
JavaScript::sendMinified();
$forIe11 = (bool) preg_match('/Trident\/7.0;.*rv:11/', $_SERVER['HTTP_USER_AGENT']);
JavaScript::sendMinified($forIe11);
break;
default:

52
library/Icinga/Web/JavaScript.php
View File

@ -53,9 +53,9 @@ class JavaScript
'js/define.js'
];
public static function sendMinified()
public static function sendMinified($forIe11 = false)
{
self::send(true);
self::send(true, $forIe11);
}
/**
@ -65,7 +65,7 @@ class JavaScript
*
* @param bool $minified Whether to compress the client side script code
*/
public static function send($minified = false)
public static function send($minified = false, $forIe11 = false)
{
header('Content-Type: application/javascript');
$basedir = Icinga::app()->getBootstrapDirectory();
@ -91,9 +91,11 @@ class JavaScript
$files[] = $filePath;
}
// Prepare library file list
foreach (Icinga::app()->getLibraries() as $library) {
$files = array_merge($files, $library->getJsAssets());
if (! $forIe11) {
// Prepare library file list
foreach (Icinga::app()->getLibraries() as $library) {
$files = array_merge($files, $library->getJsAssets());
}
}
// Prepare core file list
@ -154,26 +156,28 @@ class JavaScript
$js .= file_get_contents($file) . "\n\n\n";
}
// Library files need to be namespaced first before they can be included
foreach (Icinga::app()->getLibraries() as $library) {
foreach ($library->getJsAssets() as $file) {
$alreadyMinified = false;
if ($minified && file_exists(($minFile = substr($file, 0, -3) . '.min.js'))) {
$alreadyMinified = true;
$file = $minFile;
}
if (! $forIe11) {
// Library files need to be namespaced first before they can be included
foreach (Icinga::app()->getLibraries() as $library) {
foreach ($library->getJsAssets() as $file) {
$alreadyMinified = false;
if ($minified && file_exists(($minFile = substr($file, 0, -3) . '.min.js'))) {
$alreadyMinified = true;
$file = $minFile;
}
$content = self::optimizeDefine(
file_get_contents($file),
$file,
$library->getJsAssetPath(),
$library->getName()
);
$content = self::optimizeDefine(
file_get_contents($file),
$file,
$library->getJsAssetPath(),
$library->getName()
);
if ($alreadyMinified) {
$out .= ';' . ltrim(trim($content), ';') . "\n";
} else {
$js .= $content . "\n\n\n";
if ($alreadyMinified) {
$out .= ';' . ltrim(trim($content), ';') . "\n";
} else {
$js .= $content . "\n\n\n";
}
}
}
}

6
public/js/helpers.js
View File

@ -1,5 +1,11 @@
/*! Icinga Web 2 | (c) 2014 Icinga Development Team | GPLv2+ */
/* IE11 Polyfills */
if (window.NodeList && !NodeList.prototype.forEach) {
NodeList.prototype.forEach = Array.prototype.forEach;
}
/* jQuery Plugins */
(function ($) {

11
public/js/icinga/behavior/input-enrichment.js
View File

@ -7,9 +7,14 @@
"use strict";
var FilterInput = require('icinga/ipl/widget/FilterInput');
var TermInput = require('icinga/ipl/widget/TermInput');
var Completer = require('icinga/ipl/widget/Completer');
try {
var FilterInput = require('icinga/ipl/widget/FilterInput');
var TermInput = require('icinga/ipl/widget/TermInput');
var Completer = require('icinga/ipl/widget/Completer');
} catch (e) {
console.warn('Unable to provide input enrichments. Libraries not available:', e);
return;
}
Icinga.Behaviors = Icinga.Behaviors || {};