From 5b517a2cb0cbabe4aab4bc9dc2ac4ff7631291c8 Mon Sep 17 00:00:00 2001
From: Matthias Jentsch <matthias.jentsch@netways.de>
Date: Wed, 17 Jun 2015 17:28:28 +0200
Subject: [PATCH] Improve table layout

Add alternating colors to table rows, to improve visibillity of the table.

refs #9361
---
 .../views/scripts/config/resource.phtml       |  2 +-
 .../scripts/form/reorder-authbackend.phtml    |  2 +-
 application/views/scripts/group/list.phtml    |  2 +-
 application/views/scripts/role/list.phtml     |  2 +-
 application/views/scripts/user/list.phtml     |  2 +-
 .../views/scripts/usergroupbackend/list.phtml |  2 +-
 public/css/icinga/main-content.less           | 21 +++++++++++++++++--
 7 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/application/views/scripts/config/resource.phtml b/application/views/scripts/config/resource.phtml
index d3d0e4d4f..36822b9f0 100644
--- a/application/views/scripts/config/resource.phtml
+++ b/application/views/scripts/config/resource.phtml
@@ -5,7 +5,7 @@
   <a href="<?= $this->href('/config/createresource'); ?>">
     <?= $this->icon('plus'); ?> <?= $this->translate('Create A New Resource'); ?>
   </a>
-  <table class="action" id="resource-edit-table">
+  <table class="action alternating" id="resource-edit-table">
     <thead>
       <th><?= $this->translate('Resource'); ?></th>
       <th style="width: 5em"><?= $this->translate('Remove'); ?></th>
diff --git a/application/views/scripts/form/reorder-authbackend.phtml b/application/views/scripts/form/reorder-authbackend.phtml
index 20d4e3696..02598e013 100644
--- a/application/views/scripts/form/reorder-authbackend.phtml
+++ b/application/views/scripts/form/reorder-authbackend.phtml
@@ -1,5 +1,5 @@
 <form id="<?= $form->getId(); ?>" name="<?= $form->getName(); ?>" enctype="<?= $form->getEncType(); ?>" method="<?= $form->getMethod(); ?>" action="<?= $form->getAction(); ?>">
-  <table class="action">
+  <table class="action alternating">
     <thead>
       <th>Backend</th>
       <th style="width: 5em"><?= $this->translate('Remove'); ?></th>
diff --git a/application/views/scripts/group/list.phtml b/application/views/scripts/group/list.phtml
index 65c1591cd..1f693f152 100644
--- a/application/views/scripts/group/list.phtml
+++ b/application/views/scripts/group/list.phtml
@@ -27,7 +27,7 @@ if (! isset($backend)) {
 }
 
 if (count($groups) > 0): ?>
-<table data-base-target="_next" class="action group-list">
+<table data-base-target="_next" class="action group-list alternating">
   <thead>
     <tr>
       <th class="group-name"><?= $this->translate('Group'); ?></th>
diff --git a/application/views/scripts/role/list.phtml b/application/views/scripts/role/list.phtml
index 568bbdf98..e75c89356 100644
--- a/application/views/scripts/role/list.phtml
+++ b/application/views/scripts/role/list.phtml
@@ -6,7 +6,7 @@
         <?php /** @var \Icinga\Application\Config $roles */ if ($roles->isEmpty()): ?>
             <?= $this->translate('No roles found.') ?>
         <?php else: ?>
-            <table class="avp action" data-base-target="_next">
+            <table class="avp action alternating" data-base-target="_next">
                 <thead>
                 <tr>
                     <th><?= $this->translate('Name') ?></th>
diff --git a/application/views/scripts/user/list.phtml b/application/views/scripts/user/list.phtml
index df9a14a45..3430f7f4b 100644
--- a/application/views/scripts/user/list.phtml
+++ b/application/views/scripts/user/list.phtml
@@ -27,7 +27,7 @@ if (! isset($backend)) {
 }
 
 if (count($users) > 0): ?>
-<table data-base-target="_next" class="action user-list">
+<table data-base-target="_next" class="action user-list alternating">
   <thead>
     <tr>
       <th class="user-name"><?= $this->translate('Username'); ?></th>
diff --git a/application/views/scripts/usergroupbackend/list.phtml b/application/views/scripts/usergroupbackend/list.phtml
index 58aa2deba..49b6d5372 100644
--- a/application/views/scripts/usergroupbackend/list.phtml
+++ b/application/views/scripts/usergroupbackend/list.phtml
@@ -11,7 +11,7 @@
   )
 ); ?>
 <?php if (count($backendNames) > 0): ?>
-<table class="action usergroupbackend-list">
+<table class="action usergroupbackend-list alternating">
   <thead>
     <tr>
       <th class="backend-name"><?= $this->translate('Backend'); ?></th>
diff --git a/public/css/icinga/main-content.less b/public/css/icinga/main-content.less
index 697814df1..7b9c29821 100644
--- a/public/css/icinga/main-content.less
+++ b/public/css/icinga/main-content.less
@@ -202,14 +202,31 @@ tr[href].active {
   background-color: #eee;
   color: black;
 }
+
+table.alternating {
+  tr[href].active:nth-child(even), tr[href].active:nth-child(odd) {
+    background-color: #E5E5E5;
+    color: black;
+  }
+  tr[href]:nth-child(even) {
+    background-color: #FDFDFD;
+  }
+  tr[href]:nth-child(odd) {
+    background-color: #f5f5f5;
+  }
+  tr[href]:hover {
+    color: black;
+    background-color: #DDDDDD;
+  }
+}
 /* End of table behaviour */
 
 
 /* HOVER colors */
-
+ 
 tr[href]:hover {
   color: black;
-  background-color: #eee;
+  background-color: #DDDDDD;
 }
 /* END of HOVER colors */