tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NavigationItemRenderer: provide more human-readable aliases for native HTML link targets 

refs #10330
This commit is contained in:
Alexander A. Klimov 2015-12-17 16:13:12 +01:00
parent 2473c4bbef
commit 5edd8df1b6
1 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
library/Icinga/Web/Navigation/Renderer/NavigationItemRenderer.php
View File

@ -36,6 +36,13 @@ class NavigationItemRenderer
*/ */
protected $internalLinkTargets; protected $internalLinkTargets;
/**
* Native HTML link targets
*
* @var array
*/
protected $htmlLinkTargets;
/** /**
* Whether to escape the label * Whether to escape the label
* *
@ -59,6 +66,10 @@ class NavigationItemRenderer
'current_column' => '_self', 'current_column' => '_self',
'next_column' => '_next' 'next_column' => '_next'
); );
$this->htmlLinkTargets = array(
'current_window' => '_self',
'new_window' => '_blank'
);
$this->init(); $this->init();
} }
@ -227,26 +238,29 @@ class NavigationItemRenderer
} }
$actualTarget = $this->actualLinkTarget($target); $actualTarget = $this->actualLinkTarget($target);
if ($actualTarget === null) { if ($actualTarget !== null) {
return ' target="' . $this->view()->escape($target) . '"';
}
return ' data-base-target="' . $actualTarget . '"'; return ' data-base-target="' . $actualTarget . '"';
} }
$actualTarget = $this->actualLinkTarget($target, false);
return ' target="' . ($actualTarget === null ? $this->view()->escape($target) : $actualTarget) . '"';
}
/** /**
* If $target is an internal linktarget, return its HTML version. Otherwise, return null. * If $target is a linktarget, return its HTML version. Otherwise, return null.
* *
* @param string $target * @param string $target
* @param bool $internal Whether the target must or must not be provided by Icinga Web 2
* *
* @return string|null * @return string|null
*/ */
protected function actualLinkTarget($target) protected function actualLinkTarget($target, $internal = true)
{ {
if (isset($this->internalLinkTargets[$target])) { $linkTargets = $internal ? $this->internalLinkTargets : $this->htmlLinkTargets;
return $this->internalLinkTargets[$target]; if (isset($linkTargets[$target])) {
return $linkTargets[$target];
} }
if (in_array($target, $this->internalLinkTargets, true)) { if (in_array($target, $linkTargets, true)) {
return $target; return $target;
} }
} }