From 61a04e7ba174e92c194522b88fd9f335c5ff4294 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Mon, 18 Apr 2016 15:15:41 +0200 Subject: [PATCH] FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed fixes #10848 --- library/Icinga/Web/Widget/FilterEditor.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/library/Icinga/Web/Widget/FilterEditor.php b/library/Icinga/Web/Widget/FilterEditor.php index f512ffe67..111974310 100644 --- a/library/Icinga/Web/Widget/FilterEditor.php +++ b/library/Icinga/Web/Widget/FilterEditor.php @@ -323,11 +323,12 @@ class FilterEditor extends AbstractWidget if ($request->get('cancel') === 'Cancel') { $this->redirectNow($this->preservedUrl()->without('modifyFilter')); } - - $filter = $this->applyChanges($request->getPost()); - $url = $this->url()->setQueryString($filter->toQueryString())->addParams($preserve); - $url->getParams()->add('modifyFilter'); - $this->redirectNow($url); + if ($request->get('apply') === 'Apply') { + $filter = $this->applyChanges($request->getPost()); + $url = $this->url()->setQueryString($filter->toQueryString())->addParams($preserve); + $url->getParams()->add('modifyFilter'); + $this->redirectNow($url); + } } $this->url()->getParams()->add('modifyFilter'); }