From 62da942159f20bb1a61fdaaa5ec6974c81b0ca61 Mon Sep 17 00:00:00 2001 From: Alexander Klimov Date: Wed, 16 Jul 2014 17:49:25 +0200 Subject: [PATCH] Don't close and re-open php tags, remove unneeded spaces To close and re-open php tags makes no sense if there's nothing between them --- .../monitoring/application/controllers/ListController.php | 4 ++-- .../application/views/scripts/list/contactgroups.phtml | 7 +++---- .../application/views/scripts/list/downtimes.phtml | 7 +++---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/modules/monitoring/application/controllers/ListController.php b/modules/monitoring/application/controllers/ListController.php index ec46b8172..21361c340 100644 --- a/modules/monitoring/application/controllers/ListController.php +++ b/modules/monitoring/application/controllers/ListController.php @@ -73,9 +73,9 @@ class Monitoring_ListController extends Controller $stateColumn = 'host_hard_state'; $stateChangeColumn = 'host_last_hard_state_change'; } else { + $stateType = 'soft'; $stateColumn = 'host_state'; $stateChangeColumn = 'host_last_state_change'; - $stateType = 'soft'; } $this->addTitleTab('hosts'); @@ -148,7 +148,7 @@ class Monitoring_ListController extends Controller } } $this->setAutorefreshInterval(10); - + $columns = array_merge(array( 'host_name', 'host_state', diff --git a/modules/monitoring/application/views/scripts/list/contactgroups.phtml b/modules/monitoring/application/views/scripts/list/contactgroups.phtml index b29a5ab15..98661f4e6 100644 --- a/modules/monitoring/application/views/scripts/list/contactgroups.phtml +++ b/modules/monitoring/application/views/scripts/list/contactgroups.phtml @@ -10,9 +10,8 @@ if (count($groupData) === 0) { echo t('No contacts matching the filter'); } -?> - $groupInfo): ?> +foreach ($groupData as $groupName => $groupInfo): ?>

@@ -31,8 +30,8 @@ if (count($groupData) === 0) {

contact_email): ?> contact_email; ?> - -contact_pager): ?> +contact_pager): ?>
contact_pager; ?> diff --git a/modules/monitoring/application/views/scripts/list/downtimes.phtml b/modules/monitoring/application/views/scripts/list/downtimes.phtml index 6a6e7a3f6..995a66001 100644 --- a/modules/monitoring/application/views/scripts/list/downtimes.phtml +++ b/modules/monitoring/application/views/scripts/list/downtimes.phtml @@ -4,9 +4,9 @@ $helper = $this->getHelper('CommandForm');

tabs ?>
-sortControl->render($this); ?> +sortControl->render($this); ?>
-paginationControl($downtimes, null, null, array('preserve' => $this->preserve)); ?> +paginationControl($downtimes, null, null, array('preserve' => $this->preserve)); ?>
@@ -16,8 +16,7 @@ $helper = $this->getHelper('CommandForm'); if (count($downtimes) === 0) { echo t('No downtimes matching the filter'); } -?> -downtimes as $downtime): ?> +foreach ($this->downtimes as $downtime): ?> dateFormat()->formatDateTime($downtime->start); ?> -