tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NavigationItem: Reduce code complexity in method addChild() 

refs #5600
This commit is contained in:
Johannes Meyer 2015-09-02 15:17:26 +02:00
parent c03109c4c6
commit 62f7a49a45
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
library/Icinga/Web/Navigation/NavigationItem.php
View File

@ -224,30 +224,21 @@ class NavigationItem implements Countable, IteratorAggregate
} }
/** /**
* Add a child item to this item * Add a child to this item
* *
* Bubbles active state. * If the child is active this item gets activated as well.
* *
* @param NavigationItem|array $child The child to add * @param NavigationItem $child
* *
* @return $this * @return $this
* @throws InvalidArgumentException If the child argument is invalid
*/ */
public function addChild($child) public function addChild(NavigationItem $child)
{ {
if (! $child instanceof NavigationItem) { $this->getChildren()->addItem($child->setParent($this));
if (! is_array($child)) {
throw new InvalidArgumentException(
'Argument child must be either an array or an instance of NavigationItem'
);
}
$child = new NavigationItem($child);
}
$child->parent = $this;
$this->children->addItem($child);
if ($child->getActive()) { if ($child->getActive()) {
$this->setActive(); $this->setActive();
} }
return $this; return $this;
} }