tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add the DbAdapterFactory to instanciate database adapters using resource names 

Create the DbAdapterFactory to instanciate db adapters, add resources.ini to configure resources, change
the authentication Manager to fall back to backends with lower priority in case
of errors, update the current UserBackends to the changed environment. Also
adjust the documentation and existing unit tests.

resolves #4503
This commit is contained in:
Matthias Jentsch 2013-08-13 18:08:21 +02:00
parent 3306d3e3c0
commit 68deb735c0
15 changed files with 786 additions and 202 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
config/authentication.ini
View File

@ -1,26 +1,32 @@
[users] ; authentication.ini
backend=ldap ;
hostname=localhost ; Each section listed in this configuration represents a single backend
; that can be used to authenticate users or groups. Each databse backend must refer
; to a resource defined in resources.ini,
;
; The order of entries in this configuration is used to determine the fallback
; priority in case of an error. If the resource referenced in the first
; entry is not reachable, the next lower entry will be used for authentication.
; Please be aware that this behaviour is not valid for the authentication itself.
; The authentication will only be done against the one available resource with the highest
; priority.
[users-ldap]
backend = "ldap"
target = "user"
hostname = "localhost"
root_dn = "ou=people,dc=icinga,dc=org" root_dn = "ou=people,dc=icinga,dc=org"
bind_dn = "cn=admin,cn=config" bind_dn = "cn=admin,cn=config"
bind_pw=admin bind_pw = "admin"
user_class=inetOrgPerson user_class = "inetOrgPerson"
user_name_attribute=uid user_name_attribute = "uid"
[users-mysql] [users-mysql]
backend=Db backend = "db"
dbtype=mysql target = "user"
table=account resource = "icingaweb-mysql"
host=localhost
password=icinga
user=icingaweb
db=icingaweb
[users-pgsql] [users-pgsql]
backend=Db backend = "db"
dbtype=pgsql target = "user"
table=account resource = "icingaweb-pgsql"
host=localhost
password=icinga
user=icingaweb
db=icingaweb

0
config/preferences/KEEP.md Normal file → Executable file
View File

38
config/resources.ini Normal file
View File

@ -0,0 +1,38 @@
; resources.ini
;
; The configuration file *resources.ini* contains data sources that
; can be referenced in other configurations. This allows you to manage
; all connections to SQL databases in one single place, avoiding the need
: to edit several different configuration files, when the connection
; information of a resource change.
;
; Each section represents a resource, with the section name being the
; identifier used to reference this certain section. Depending on the
; resource type, each section contains different properties. The property
; *type* defines the resource type and thus how the properties are going to
; be interpreted. Currently only the resource type *db* is available.
[icingaweb-pgsql]
type = db
db = pgsql ; PostgreSQL
host = localhost
password = icinga
username = icingaweb
dbname = icingaweb
[icingaweb-mysql]
type = db
db = mysql ; MySQL
host = localhost
password = icinga
username = icingaweb
dbname = icingaweb
[ido]
type = db
dbname = mysql
host = localhost
password = icinga
username = icingaweb
db = icingaweb

58
doc/authentication.md
View File

@ -1,29 +1,59 @@
# Authentication via internal DB # Authentication
The class DbUserBackend allows to handle the user authentication internally in a database. The authentication manager can use different backend types like LDAP or Databases as data sources. During
the application bootstrap the different available resources are checked for availability and
the resource with the highest priority will be used for authentication. This behaviour is useful for setting
up fallback accounts, that are available when the regular authentication backend is not available.
## Configuration ## Configuration
The internal authentication is configured in *config/authentication.ini*. The value The internal authentication is configured in *config/authentication.ini*.
of the configuration key "backend" will determine which UserBackend class to
Each section listed in this configuration represents a single backend
that can be used to authenticate users or groups.
The order of entries in this configuration is used to determine the fallback
priority in case of an error. If the resource referenced in the first entry (the one at the top if the file)
is not reachable, the next lower entry will be used for authentication.
Please be aware that this behaviour is not valid for the authentication itself.
The authentication will only be done against the one available resource with the highest
priority.
### Backend
The value of the configuration key *backend* will determine which UserBackend class to
load. To use the internal backend you need to specifiy the value "Db" load. To use the internal backend you need to specifiy the value "Db"
which will cause the class "DbUserBackend" to be loaded. which will cause the class "DbUserBackend" to be loaded.
There are various configuration keys in "Authentication.ini" and some are only Currently these types of backends are allowed:
used by specific backends. The internal DB uses the values * ldap
*dbtype*,*table*,*host*,*password*,*user* and *db*, which define the used * db
connection parameters, the database and the table.
## Database support #### db
The module currently supports these databases: The authentication source is a SQL database and points to a resource defined in *resources.ini*, which
contains all the connection information. Every entry should therefore contain a property *resource*
with the name of the assigned resource. For a more detailed description about how to set up resources,
please read the chapter *Resources*.
- mysql (dbtype=mysql) The authentication currently supports the databases MySQL and PostgreSQL.
- PostgreSQL (dbtype=pgsql)
#### ldap
The authentication source is an ldap server. The connection information should be directly present
in the *authentication.ini*, like described in the example configuration.
## Authentication ### target
The backend will store the salted hash of the password in the column "password" and the salt in the column "salt". The value of the configuration key *target* defines
## Technical description
If an ldap-backend is used, the standard ldap bind will be executed and all user credentials will be managed
directly by the ldap server.
In case of an SQL-backend, the backend will store the salted hash of the password in the column "password" and the salt in the column "salt".
When a password is checked, the hash is calculated with the function hash_hmac("sha256",salt,password) and compared When a password is checked, the hash is calculated with the function hash_hmac("sha256",salt,password) and compared
to the stored value. to the stored value.

22
doc/resources.md Normal file
View File

@ -0,0 +1,22 @@
# Resources
The configuration file *config/resources.ini* contains data sources that can be referenced
in other configurations. This allows you to manage all connections to SQL databases in one
single place, avoiding the need to edit several different configuration files, when the
connection information of a resource change.
## Configuration
Each section represents a resource, with the section name being the identifier used to
reference this certain section. Depending on the resource type, each section contains different properties.
The property *type* defines the resource type and thus how the properties are going to be interpreted.
Currently only the resource type *db* is available.
### db
This resource type represents a SQL database. The property *db* defines the used sql database, which
could be a value like *mysql* or *pgsql*. The other properties like *host*, *password*, *username* and
*dbname* are the connection information for the resource.

18
library/Icinga/Application/ApplicationBootstrap.php
View File

@ -34,6 +34,8 @@ use Zend_Loader_Autoloader;
use Icinga\Application\Modules\Manager as ModuleManager; use Icinga\Application\Modules\Manager as ModuleManager;
use Icinga\Application\Platform; use Icinga\Application\Platform;
use \Icinga\Application\Config; use \Icinga\Application\Config;
use Icinga\Exception\ProgrammingError;
use Icinga\Application\DbAdapterFactory;
use Icinga\Exception\ConfigurationError; use Icinga\Exception\ConfigurationError;
use Icinga\Util\DateTimeFactory; use Icinga\Util\DateTimeFactory;
@ -341,7 +343,23 @@ abstract class ApplicationBootstrap
} }
/** /**
<<<<<<< HEAD
* Setup time zone * Setup time zone
=======
* Setup factories that provide access to the resources
*
* @return self
*/
protected function setupResourceFactories()
{
$config = Config::app('resources');
DbAdapterFactory::setConfig($config);
return $this;
}
/**
* Setup default timezone
>>>>>>> Add the DbAdapterFactory to instanciate database adapters using resource names
* *
* @return self * @return self
* @throws ConfigurationError if the timezone in config.ini isn't valid * @throws ConfigurationError if the timezone in config.ini isn't valid

42
library/Icinga/Application/ConfigAwareFactory.php Normal file
View File

@ -0,0 +1,42 @@
<?php
// {{{ICINGA_LICENSE_HEADER}}}
/**
* This file is part of Icinga 2 Web.
*
* Icinga 2 Web - Head for multiple monitoring backends.
* Copyright (C) 2013 Icinga Development Team
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* @copyright 2013 Icinga Development Team <info@icinga.org>
* @license http://www.gnu.org/licenses/gpl-2.0.txt GPL, version 2
* @author Icinga Development Team <info@icinga.org>
*/
// {{{ICINGA_LICENSE_HEADER}}}
namespace Icinga\Application;
/**
* A factory that is configurable
*/
interface ConfigAwareFactory {
/**
* Set the factory configuration
*
* @param mixed $config The configuration
*/
public static function setConfig($config);
}

170
library/Icinga/Application/DbAdapterFactory.php Normal file
View File

@ -0,0 +1,170 @@
<?php
// {{{ICINGA_LICENSE_HEADER}}}
/**
* This file is part of Icinga 2 Web.
*
* Icinga 2 Web - Head for multiple monitoring backends.
* Copyright (C) 2013 Icinga Development Team
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* @copyright 2013 Icinga Development Team <info@icinga.org>
* @license http://www.gnu.org/licenses/gpl-2.0.txt GPL, version 2
* @author Icinga Development Team <info@icinga.org>
*/
// {{{ICINGA_LICENSE_HEADER}}}
namespace Icinga\Application;
use Zend_Config;
use Zend_Db;
use Icinga\Application\Logger;
use Icinga\Exception\ConfigurationError;
use Icinga\Exception\ProgrammingError;
use Tests\Icinga\Application\ZendDbMock;
/**
* Create resources using short identifiers referring to configuration entries
*/
class DbAdapterFactory implements ConfigAwareFactory {
/**
* Resource definitions
*
* @var Zend_Config
*/
private static $resources;
/**
* The factory class used to create instances of Zend_Db_Adapter
*
* @var String
*/
private static $factoryClass;
/**
* Resource cache to allow multiple use
*
* @var array
*/
private static $resourceCache = array();
/**
* Set the configuration that stores the available resources
*
* @param mixed $config The configuration containing the resources
*
* @param array $options Additional options that affect the factories behaviour:
* * factory : Set the factory class that creates instances
* of Zend_Db_Adapter for the different database types
* (used for testing)
*/
public static function setConfig($config, array $options = null)
{
self::$resources = $config;
if (isset($options['factory'])) {
self::$factoryClass = $options['factory'];
} else {
self::$factoryClass = 'Zend_Db';
}
}
/**
* Reset the factory configuration back to the default state
*/
public static function resetConfig()
{
unset(self::$resources);
unset(self::$factoryClass);
}
/**
* Get the resource with the given $identifier
*
* @param $identifier The name of the resource
*/
public static function getDbAdapter($identifier)
{
if (!isset(self::$resources)) {
$msg = 'Creation of resource ' . $identifier . ' not possible, because there is no configuration present.'
. ' Make shure this factory class was initiated correctly during the application bootstrap.';
Logger::error($msg);
throw new ProgrammingError($msg);
}
if (!isset(self::$resources->{$identifier})) {
$msg = 'Creation of resource "'
. $identifier
. '" not possible, because there is no matching resource present in the configuration ';
Logger::error($msg);
throw new ConfigurationError($msg);
}
if (array_key_exists($identifier,self::$resourceCache)) {
return self::$resourceCache[$identifier];
} else {
$res = self::createDbAdapter(self::$resources->{$identifier});
self::$resourceCache[$identifier] = $res;
return $res;
}
}
/**
* Create the Db_Adapter for the given configuration section
*
* @param mixed $config The configuration section containing the
* db information
*
* @return \Zend_Db_Adapter_Abstract The created Zend_Db_Adapter
*
* @throws \ConfigurationError When the specified db type is invalid
*/
private static function createDbAdapter($config)
{
if ($config->type !== 'db') {
throw new ConfigurationError(
'Resource type must be "db" but is "' . $config->type . '"');
}
$options = array(
'dbname' => $config->dbname,
'host' => $config->host,
'username' => $config->username,
'password' => $config->password,
);
switch ($config->db) {
case 'mysql':
return self::callFactory('Pdo_Mysql',$options);
case 'pgsql':
return self::callFactory('Pdo_Pgsql',$options);
default:
throw new ConfigurationError('Unsupported db type ' . $config->db . '.');
}
}
/**
* Call the currently set factory class
*
* @param $adapter The name of the used db adapter
* @param $options OPTIONAL: an array or Zend_Config object with adapter
* parameters
*
* @return Zend_Db_Adapter_Abstract The created adapter
*/
private static function callFactory($adapter, $options)
{
$factory = self::$factoryClass;
return $factory::factory($adapter,$options);
}
}

1
library/Icinga/Application/Web.php
View File

@ -93,6 +93,7 @@ class Web extends ApplicationBootstrap
return $this->setupConfig() return $this->setupConfig()
->setupErrorHandling() ->setupErrorHandling()
->setupTimezone() ->setupTimezone()
->setupResourceFactories()
->setupRequest() ->setupRequest()
->setupZendMvc() ->setupZendMvc()
->setupTranslation() ->setupTranslation()

40
library/Icinga/Authentication/Backend/DbUserBackend.php
View File

@ -53,11 +53,11 @@ class DbUserBackend implements UserBackend {
private $db = null; private $db = null;
/** /**
* The name of the user table as provided by the configuration * The name of the user table
* *
* @var String * @var String
*/ */
private $userTable; private $userTable = "account";
/** /**
* Mapping of columns * Mapping of columns
@ -74,45 +74,19 @@ class DbUserBackend implements UserBackend {
$DOMAIN_COLUMN = 'domain', $DOMAIN_COLUMN = 'domain',
$EMAIL_COLUMN = 'email'; $EMAIL_COLUMN = 'email';
/**
* Map the configuration dbtypes to the corresponding Zend-PDOs
*
* @var Array
*/
private $dbTypeMap = Array(
'mysql' => 'PDO_MYSQL',
'pgsql' => 'PDO_PGSQL'
);
/** /**
* Create a DbUserBackend * Create a DbUserBackend
* *
* @param $config The configuration-object containing the members host,user,password,db * @param Zend_Db The database that provides the authentication data
*/ */
public function __construct($config) public function __construct($database)
{ {
$this->dbtype = $config->dbtype; $this->db = $database;
$this->userTable = $config->table;
try {
$this->db = \Zend_Db::factory(
$this->dbTypeMap[$config->dbtype],
array(
'host' => $config->host,
'username' => $config->user,
'password' => $config->password,
'dbname' => $config->db
));
/* /*
* Test the connection settings * Test if the connection is available
*/ */
$this->db->getConnection(); $this->db->getConnection();
$this->db->select()->from($this->userTable,new \Zend_Db_Expr('TRUE'));
} catch (\Zend_Db_Adapter_Exception $exc) {
Logger::error('Could not authenticate via database : %s ', $exc->getMessage());
$this->db = null;
}
} }
/** /**
@ -180,6 +154,7 @@ class DbUserBackend implements UserBackend {
* Fetch the users salt from the database * Fetch the users salt from the database
* *
* @param $username The user whose salt should be fetched. * @param $username The user whose salt should be fetched.
*
* @return String|null Returns the salt-string or Null, when the user does not exist. * @return String|null Returns the salt-string or Null, when the user does not exist.
*/ */
private function getUserSalt($username) private function getUserSalt($username)
@ -196,6 +171,7 @@ class DbUserBackend implements UserBackend {
* Fetch the user information from the database * Fetch the user information from the database
* *
* @param $username The name of the user. * @param $username The name of the user.
*
* @return User|null Returns the user object, or null when the user does not exist. * @return User|null Returns the user object, or null when the user does not exist.
*/ */
private function getUserByName($username) private function getUserByName($username)

14
library/Icinga/Authentication/Backend/LdapUserBackend.php
View File

@ -49,6 +49,13 @@ class LdapUserBackend implements UserBackend
**/ **/
protected $connection; protected $connection;
/**
* The ldap connection information
*
* @var object
*/
private $config;
/** /**
* Creates a new Authentication backend using the * Creates a new Authentication backend using the
* connection information provided in $config * connection information provided in $config
@ -58,6 +65,7 @@ class LdapUserBackend implements UserBackend
public function __construct($config) public function __construct($config)
{ {
$this->connection = new Ldap\Connection($config); $this->connection = new Ldap\Connection($config);
$this->config = $config;
} }
/** /**
@ -95,13 +103,13 @@ class LdapUserBackend implements UserBackend
{ {
return $this->connection->select() return $this->connection->select()
->from( ->from(
IcingaConfig::app('authentication')->users->user_class, $this->config->user_class,
array( array(
IcingaConfig::app('authentication')->users->user_name_attribute $this->config->user_name_attribute
) )
) )
->where( ->where(
IcingaConfig::app('authentication')->users->user_name_attribute, $this->config->user_name_attribute,
$this->stripAsterisks($username) $this->stripAsterisks($username)
); );
} }

85
library/Icinga/Authentication/Manager.php
View File

@ -30,6 +30,7 @@ namespace Icinga\Authentication;
use Icinga\Application\Logger; use Icinga\Application\Logger;
use \Icinga\Application\Config as IcingaConfig; use \Icinga\Application\Config as IcingaConfig;
use Icinga\Application\DbAdapterFactory;
use Icinga\Exception\ConfigurationError as ConfigError; use Icinga\Exception\ConfigurationError as ConfigError;
use Icinga\User; use Icinga\User;
@ -103,14 +104,14 @@ class Manager
} }
if (isset($options["userBackendClass"])) { if (isset($options["userBackendClass"])) {
$this->userBackend = $options["userBackendClass"]; $this->userBackend = $options["userBackendClass"];
} elseif ($config->users !== null) { } else {
$this->userBackend = $this->initBackend(self::BACKEND_TYPE_USER, $config->users); $this->userBackend = $this->initBestBackend(self::BACKEND_TYPE_USER, $config);
} }
if (isset($options["groupBackendClass"])) { if (isset($options["groupBackendClass"])) {
$this->groupBackend = $options["groupBackendClass"]; $this->groupBackend = $options["groupBackendClass"];
} elseif ($config->groups != null) { } else {
$this->groupBackend = $this->initBackend(self::BACKEND_TYPE_GROUP, $config->groups); $this->groupBackend = $this->initBestBackend(self::BACKEND_TYPE_GROUP, $config);
} }
if (!isset($options["sessionClass"])) { if (!isset($options["sessionClass"])) {
@ -137,7 +138,7 @@ class Manager
} }
/** /**
* Clears the instance (this is mostly needed for testing and shouldn't be called otherwise) * Clear the instance (this is mostly needed for testing and shouldn't be called otherwise)
**/ **/
public static function clearInstance() public static function clearInstance()
{ {
@ -145,35 +146,67 @@ class Manager
} }
/** /**
* Creates a backend for the the given authenticationTarget (User or Group) and the * Create a connection to the best available backend
* Authenticaiton source.
* *
* initBackend("User", "Ldap") would create a UserLdapBackend, * @param String $target "User" or "Group", depending on what
* initBackend("Group", "MySource") would create a GroupMySourceBackend, * authentication information the backend should provide
* * @param Mixed $backends The configuration containing all backend configurations
* Supported backends can be found in the Authentication\Backend folder * in falling priority
*
* @param String $authenticationTarget "User" or "Group", depending on what
* authentication information the backend should
* provide
* @param String $authenticationSource The Source, see the above examples
* *
* @return (null|UserBackend|GroupBackend) * @return (null|UserBackend|GroupBackend)
**/ */
private function initBackend($authenticationTarget, $authenticationSource) private function initBestBackend($target, $backends)
{ {
$backend = ucwords(strtolower($authenticationSource->backend)); foreach ($backends as $backend) {
if (strtolower($target) === strtolower($backend->target)) {
if (!$backend) { $db = $this->tryToInitBackend($target,$backend);
if (isset($db)) {
break;
}
}
}
if (!isset($db)) {
$msg = 'Failed to create any authentication backend, login will not be possible.';
Logger::error($msg);
return null; return null;
} }
return $db;
$class = '\\Icinga\\Authentication\\Backend\\' . $backend . $authenticationTarget. 'Backend';
return new $class($authenticationSource);
} }
/** /**
* Tries to authenticate the current user with the Credentials (@see Credentials). * Try to create the backend with the given configuration
*
* @param String $target "User" or "Group", depending on what
* authentication information the backend should provide
* @param $backendConfig The configuration containing backend description
*
* @return UserBackend|null Return the created backend or null
*/
private function tryToInitBackend($target, $backendConfig)
{
$type = ucwords(strtolower($backendConfig->backend));
if (!$type) {
return null;
}
try {
if ($backendConfig->backend === 'db') {
$resource = DbAdapterFactory::getDbAdapter($backendConfig->resource);
} else {
$resource = $backendConfig;
}
$class = '\\Icinga\\Authentication\\Backend\\' . $type . $target. 'Backend';
return new $class($resource);
} catch (\Exception $e) {
$msg = 'Not able to create backend: ' .
print_r($backendConfig->backend,true)
. '. Exception: ' . $e->getMessage();
Logger::warn($msg);
return null;
}
}
/**
* Try to authenticate the current user with the Credentials (@see Credentials).
* *
* @param Credentials $credentials The credentials to use for authentication * @param Credentials $credentials The credentials to use for authentication
* @param Boolean $persist Whether to persist the authentication result * @param Boolean $persist Whether to persist the authentication result
@ -212,7 +245,6 @@ class Manager
/** /**
* Writes the current user to the session (only usable when writeSession = true) * Writes the current user to the session (only usable when writeSession = true)
*
**/ **/
public function persistCurrentUser() public function persistCurrentUser()
{ {
@ -244,7 +276,6 @@ class Manager
/** /**
* Purges the current authorisation information and deletes the session * Purges the current authorisation information and deletes the session
*
**/ **/
public function removeAuthorization() public function removeAuthorization()
{ {

159
test/php/library/Icinga/Application/DbAdapterFactoryTest.php Normal file
View File

@ -0,0 +1,159 @@
<?php
// {{{ICINGA_LICENSE_HEADER}}}
/**
* This file is part of Icinga 2 Web.
*
* Icinga 2 Web - Head for multiple monitoring backends.
* Copyright (C) 2013 Icinga Development Team
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* @copyright 2013 Icinga Development Team <info@icinga.org>
* @license http://www.gnu.org/licenses/gpl-2.0.txt GPL, version 2
* @author Icinga Development Team <info@icinga.org>
*/
// {{{ICINGA_LICENSE_HEADER}}}
namespace Tests\Icinga\Application;
require_once('Zend/Db.php');
require_once('Zend/Db/Adapter/Pdo/Mysql.php');
require_once('Zend/Config.php');
require_once('Zend/Log.php');
require_once('Zend/Config.php');
require_once('../../library/Icinga/Application/Logger.php');
require_once('library/Icinga/Application/ZendDbMock.php');
require_once('../../library/Icinga/Exception/ConfigurationError.php');
require_once('../../library/Icinga/Application/ConfigAwareFactory.php');
require_once('../../library/Icinga/Application/DbAdapterFactory.php');
use Tests\Icinga\Application\ZendDbMock;
use Icinga\Application\DbAdapterFactory;
use Icinga\Exception\ConfigurationError;
/*
* Unit test for the class DbAdapterFactory
*/
class DbAdapterFactoryTest extends \PHPUnit_Framework_TestCase {
/**
* The resources used for this test
*/
private $resources;
/**
* Set up the test fixture
*/
public function setUp()
{
$resources = array(
/*
* PostgreSQL databse
*/
'resource1' => array(
'type' => 'db',
'db' => 'pgsql',
'dbname' => 'resource1',
'host' => 'host1',
'username' => 'username1',
'password' => 'password1'
),
/*
* MySQL database
*/
'resource2' => array(
'type' => 'db',
'db' => 'mysql',
'dbname' => 'resource2',
'host' => 'host2',
'username' => 'username2',
'password' => 'password2'
),
/*
* Unsupported database type
*/
'resource3' => array(
'type' => 'db',
'db' => 'mssql',
'dbname' => 'resource3',
'host' => 'host3',
'username' => 'username3',
'password' => 'password3'
),
/*
* Unsupported resource type
*/
'resource4' => array(
'type' => 'ldap',
),
);
$this->resources = new \Zend_Config($resources);
DbAdapterFactory::setConfig(
$this->resources,
array(
'factory' => 'Tests\Icinga\Application\ZendDbMock'
)
);
}
public function testGetValidResource()
{
DbAdapterFactory::getDbAdapter('resource2');
$this->assertEquals(
'Pdo_Mysql',
ZendDbMock::getAdapter(),
'The db adapter name must be Pdo_Mysql.');
$this->assertEquals(
$this->getOptions($this->resources->{'resource2'}),
ZendDbMock::getConfig(),
'The options must match the original config file content'
);
}
/**
* Test if an exception is thrown, when an invalid database is used.
*
* @expectedException \Exception
*/
public function testGetInvalidDatabase()
{
DbAdapterFactory::getDbAdapter('resource3');
}
/**
* Test if an exception is thrown, when an invalid type is used.
*
* @expectedException \Exception
*/
public function testGetInvalidType()
{
DbAdapterFactory::getDbAdapter('resource4');
}
/**
* Prepare the options object for assertions
*
* @param Zend_Config $config The configuration to prepare
*
* @return array The prepared options object
*/
private function getOptions($config)
{
$options = array_merge(array(),$config->toArray());
unset($options['type']);
unset($options['db']);
return $options;
}
}

86
test/php/library/Icinga/Application/ZendDbMock.php Normal file
View File

@ -0,0 +1,86 @@
<?php
// {{{ICINGA_LICENSE_HEADER}}}
/**
* This file is part of Icinga 2 Web.
*
* Icinga 2 Web - Head for multiple monitoring backends.
* Copyright (C) 2013 Icinga Development Team
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* @copyright 2013 Icinga Development Team <info@icinga.org>
* @license http://www.gnu.org/licenses/gpl-2.0.txt GPL, version 2
* @author Icinga Development Team <info@icinga.org>
*/
// {{{ICINGA_LICENSE_HEADER}}}
namespace Tests\Icinga\Application;
/**
* Partially emulate the functionality of Zend_Db
*/
class ZendDbMock {
/**
* The config that was used in the last call of the factory function
*
* @var mixed
*/
private static $config;
/**
* Name of the adapter class that was used in the last call of the factory function
*
* @var mixed
*/
private static $adapter;
/**
* Mock the factory-method of Zend_Db and save the given parameters
*
* @param $adapter String name of base adapter class, or Zend_Config object
* @param $config mixed OPTIONAL; an array or Zend_Config object with adapter
* parameters
*
* @return stdClass Empty object
*/
public static function factory($adapter, $config)
{
self::$config = $config;
self::$adapter = $adapter;
return new \stdClass();
}
/**
* Get the name of the adapter class that was used in the last call
* of the factory function
*
* @return String
*/
public static function getAdapter()
{
return self::$adapter;
}
/**
* Get the config that was used in the last call of the factory function
*
* @return mixed
*/
public static function getConfig()
{
return self::$config;
}
}

5
test/php/library/Icinga/Authentication/DbUserBackendTest.php
View File

@ -29,9 +29,6 @@
namespace Tests\Icinga\Authentication; namespace Tests\Icinga\Authentication;
//use Icinga\Protocol\Ldap\Exception;
//use Zend_Config_Ini;
require_once('Zend/Config/Ini.php'); require_once('Zend/Config/Ini.php');
require_once('Zend/Db.php'); require_once('Zend/Db.php');
require_once('../../library/Icinga/Authentication/UserBackend.php'); require_once('../../library/Icinga/Authentication/UserBackend.php');
@ -147,7 +144,7 @@ class DbUserBackendTest extends \PHPUnit_Framework_TestCase {
$config->dbtype = $dbType; $config->dbtype = $dbType;
$db = $this->createDb($dbType,$config); $db = $this->createDb($dbType,$config);
$this->setUpDb($db); $this->setUpDb($db);
return new DbUserBackend($config); return new DbUserBackend($db);
} catch(\Exception $e) { } catch(\Exception $e) {
echo 'CREATE_BACKEND_ERROR:'.$e->getMessage(); echo 'CREATE_BACKEND_ERROR:'.$e->getMessage();
return null; return null;