tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-31 01:34:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

RepositoryQuery: Do not sort by converted columns for limited queries

Browse Source 
A limited query with conversion rules makes it impossible to sort
the result.
This commit is contained in:
Johannes Meyer 2015-06-26 14:24:03 +02:00
parent 56c506c8af
commit 9055eb9cb7
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
library/Icinga/Repository/RepositoryQuery.php
View File

@ -264,6 +264,16 @@ class RepositoryQuery implements QueryInterface, Iterator
foreach ($sortColumns['columns'] as $column) {
list($column, $specificDirection) = $this->splitOrder($column);
if ($this->hasLimit() && $this->repository->providesValueConversion($this->target, $column)) {
Logger::debug(
'Cannot order by column "%s" in repository "%s". The query is'
. ' limited and applies value conversion rules on the column',
$column,
$this->repository->getName()
);
continue;
}
try {
$this->query->order(
$this->repository->requireFilterColumn($this->target, $column, $this),