From 9092a5d335cd23ef5ff941b162a8607b35228c04 Mon Sep 17 00:00:00 2001
From: Jolien Trog <jolien.trog@icinga.com>
Date: Thu, 28 Aug 2025 16:47:17 +0200
Subject: [PATCH] codereview

---
 application/forms/Account/ChangePasswordForm.php | 12 ++++--------
 application/forms/Config/User/UserForm.php       | 11 ++++-------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/application/forms/Account/ChangePasswordForm.php b/application/forms/Account/ChangePasswordForm.php
index 73511e8fa..a21f41adb 100644
--- a/application/forms/Account/ChangePasswordForm.php
+++ b/application/forms/Account/ChangePasswordForm.php
@@ -37,20 +37,16 @@ class ChangePasswordForm extends Form
      */
     public function createElements(array $formData)
     {
-        $passwordPolicyObject = null;
         $passwordPolicy = Config::app()->get(
             'global',
             'password_policy',
             DefaultPasswordPolicy::class
         );
+        $passwordPolicyObject = new $passwordPolicy();
+        $passwordPolicyDescription = $passwordPolicyObject->getDescription();
 
-        if (isset($passwordPolicy)) {
-            $passwordPolicyObject = new $passwordPolicy();
-            $passwordPolicyDescription = $passwordPolicyObject->getDescription();
-
-            if ($passwordPolicyDescription != '') {
-                $this->addDescription($passwordPolicyDescription);
-            }
+        if ($passwordPolicyDescription != '') {
+            $this->addDescription($passwordPolicyDescription);
         }
 
         $this->addElement(
diff --git a/application/forms/Config/User/UserForm.php b/application/forms/Config/User/UserForm.php
index 8d8a591e7..19a778f70 100644
--- a/application/forms/Config/User/UserForm.php
+++ b/application/forms/Config/User/UserForm.php
@@ -20,19 +20,16 @@ class UserForm extends RepositoryForm
      */
     protected function createInsertElements(array $formData)
     {
-        $passwordPolicyObject = null;
         $passwordPolicy = Config::app()->get(
             'global',
             'password_policy',
             DefaultPasswordPolicy::class
         );
-        if (isset($passwordPolicy)) {
-            $passwordPolicyObject = new $passwordPolicy();
-            $passwordPolicyDescription = $passwordPolicyObject->getDescription();
+        $passwordPolicyObject = new $passwordPolicy();
+        $passwordPolicyDescription = $passwordPolicyObject->getDescription();
 
-            if ($passwordPolicyDescription != '') {
-                $this->addDescription($passwordPolicyDescription);
-            }
+        if ($passwordPolicyDescription != '') {
+            $this->addDescription($passwordPolicyDescription);
         }
 
         $this->addElement(