From 98b2bce15e40a26356e1c07d3aff710def579e7d Mon Sep 17 00:00:00 2001 From: Johannes Meyer Date: Wed, 27 Aug 2014 10:09:29 +0200 Subject: [PATCH] Icinga\Web\Form::onSuccess() must not return TRUE When using Icinga\Web\Form directly without creating a specific sub-class and calling handleRequest() one must not get redirected. refs #5525 --- library/Icinga/Web/Form.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/Icinga/Web/Form.php b/library/Icinga/Web/Form.php index fdeb0cd8b..303abc711 100644 --- a/library/Icinga/Web/Form.php +++ b/library/Icinga/Web/Form.php @@ -229,7 +229,7 @@ class Form extends Zend_Form /** * Perform actions after this form was submitted using a valid request * - * Intended to be implemented by concrete form classes. + * Intended to be implemented by concrete form classes. The base implementation returns always FALSE. * * @param Request $request The valid request used to process this form * @@ -237,7 +237,7 @@ class Form extends Zend_Form */ public function onSuccess(Request $request) { - return true; + return false; } /**