From 9b938990680129f3a402f52e051223b9d07a640d Mon Sep 17 00:00:00 2001 From: Eric Lippmann Date: Tue, 26 Feb 2019 09:59:24 +0100 Subject: [PATCH] Merge pull request #3667 from Icinga/bugfix/undefined-offset-100-3589 Format::seconds(): handle negative values as expected (cherry picked from commit 57f54b0f76708f0bb7894b8f4f2583db9872ca8f) Signed-off-by: Johannes Meyer --- library/Icinga/Util/Format.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/library/Icinga/Util/Format.php b/library/Icinga/Util/Format.php index f3e682128..79839b825 100644 --- a/library/Icinga/Util/Format.php +++ b/library/Icinga/Util/Format.php @@ -54,11 +54,13 @@ class Format public static function seconds($value) { - if ($value < 60) { + $absValue = abs($value); + + if ($absValue < 60) { return self::formatForUnits($value, self::$secondPrefix, self::$secondBase); - } elseif ($value < 3600) { + } elseif ($absValue < 3600) { return sprintf('%0.2f m', $value / 60); - } elseif ($value < 86400) { + } elseif ($absValue < 86400) { return sprintf('%0.2f h', $value / 3600); }