From 9e66d22c762b9ab7d92092698d146e7050aa0f22 Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Tue, 18 Feb 2014 17:43:57 +0000 Subject: [PATCH] One more TODO: Query-String handling in action controller --- library/Icinga/Web/Controller/ActionController.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/library/Icinga/Web/Controller/ActionController.php b/library/Icinga/Web/Controller/ActionController.php index e20f276ee..a7c6542b6 100755 --- a/library/Icinga/Web/Controller/ActionController.php +++ b/library/Icinga/Web/Controller/ActionController.php @@ -228,7 +228,11 @@ class ActionController extends Zend_Controller_Action $base = $this->_request->getModuleName() . '/' . $this->_request->getControllerName() . '/' . $this->_request->getActionName(); - return $_SERVER['QUERY_STRING'] !== '' ? $base . '?' . $_SERVER['QUERY_STRING'] : $base; + // TODO: We should NOT fiddle with Querystring here in the middle of nowhere + if (isset($_SERVER['QUERY_STRING']) && $_SERVER['QUERY_STRING'] !== '') { + return $base . '?' . $_SERVER['QUERY_STRING']; + } + return $base; } /**