tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-09-25 18:59:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

codereview: Improve type hints and return types

Browse Source
This commit is contained in:
Jolien Trog 2025-09-02 15:59:18 +02:00
parent 1782e97c92
commit a1ab6975d5
3 changed files with 26 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
modules/password-policy Normal file
View File

52
test/php/library/Icinga/Application/CommonPasswordPolicyTest.php
View File

@ -8,79 +8,71 @@ use Icinga\Test\BaseTestCase;
class CommonPasswordPolicyTest extends BaseTestCase class CommonPasswordPolicyTest extends BaseTestCase
{ {
private object $object; private PasswordPolicyHook $instance;
public function setUp(): void public function setUp(): void
{ {
$this->object = new CommonPasswordPolicy(); $this->instance = new CommonPasswordPolicy();
}
public function testClassIsInstanzOf()
{
$this->assertInstanceOf(PasswordPolicyHook::class, $this->object);
} }
public function testMethodGetName(): void public function testMethodGetName(): void
{ {
$this->assertSame('Common', $this->object->getName()); $this->assertSame('Common', $this->instance->getName());
} }
public function testValidatePasswordTooShort() public function testValidatePasswordTooShort(): void
{ {
$res = $this->object->validatePassword('Icinga1#'); $res = $this->instance->validatePassword('Icinga1#');
$this->assertSame('Password must be at least 12 characters long', $res[0]); $this->assertSame('Password must be at least 12 characters long', $res[0]);
$this->assertCount(1, $res); $this->assertCount(1, $res);
} }
public function testValidatePasswordNoNumber() public function testValidatePasswordNoNumber(): void
{ {
$res = $this->object->validatePassword('Icingaadmin#'); $res = $this->instance->validatePassword('Icingaadmin#');
$this->assertSame('Password must contain at least one number', $res[0]); $this->assertSame('Password must contain at least one number', $res[0]);
var_dump($res);
$this->assertCount(1, $res); $this->assertCount(1, $res);
} }
public function testValidatePasswordNoSpecialCharacter() public function testValidatePasswordNoSpecialCharacter(): void
{ {
$res = $this->object->validatePassword('Icingaadmin1'); $res = $this->instance->validatePassword('Icingaadmin1');
$this->assertSame('Password must contain at least one special character', $res[0]); $this->assertSame('Password must contain at least one special character', $res[0]);
$this->assertCount(1, $res); $this->assertCount(1, $res);
} }
public function testValidatePasswordNoUpperCaseLetters() public function testValidatePasswordNoUpperCaseLetters(): void
{ {
$res = $this->object->validatePassword('icingaadmin1#'); $res = $this->instance->validatePassword('icingaadmin1#');
$this->assertSame('Password must contain at least one uppercase letter', $res[0]); $this->assertSame('Password must contain at least one uppercase letter', $res[0]);
$this->assertCount(1, $res); $this->assertCount(1, $res);
} }
public function testValidatePasswordNoLowerCaseLetters() public function testValidatePasswordNoLowerCaseLetters(): void
{ {
$res = $this->object->validatePassword('ICINGAADMIN1#'); $res = $this->instance->validatePassword('ICINGAADMIN1#');
$this->assertSame('Password must contain at least one lowercase letter', $res[0]); $this->assertSame('Password must contain at least one lowercase letter', $res[0]);
$this->assertCount(1, $res); $this->assertCount(1, $res);
} }
public function testValidatePasswordValid() public function testValidatePasswordValid(): void
{ {
$res = $this->object->validatePassword('Icingaadmin1#'); $res = $this->instance->validatePassword('Icingaadmin1#');
$this->assertEmpty($res); $this->assertEmpty($res);
} }
public function testValidatePasswordOnlyLowerCaseLetters() public function testValidatePasswordOnlyLowerCaseLetters(): void
{ {
$res = $this->object->validatePassword('icingawebadmin'); $res = $this->instance->validatePassword('icingawebadmin');
var_dump($res);
$this->assertCount(3, $res); $this->assertCount(3, $res);
$this->assertSame('Password must contain at least one number', $res[0]); $this->assertSame('Password must contain at least one number', $res[0]);
$this->assertSame('Password must contain at least one special character', $res[1]); $this->assertSame('Password must contain at least one special character', $res[1]);
$this->assertSame('Password must contain at least one uppercase letter', $res[2]); $this->assertSame('Password must contain at least one uppercase letter', $res[2]);
} }
public function testValidatePasswordWithLengthAndUpperCaseLetters() public function testValidatePasswordWithLengthAndUpperCaseLetters(): void
{ {
$res = $this->object->validatePassword('ICINGAADMIN'); $res = $this->instance->validatePassword('ICINGAADMIN');
var_dump($res);
$this->assertCount(4, $res); $this->assertCount(4, $res);
$this->assertSame('Password must be at least 12 characters long', $res[0]); $this->assertSame('Password must be at least 12 characters long', $res[0]);
$this->assertSame('Password must contain at least one number', $res[1]); $this->assertSame('Password must contain at least one number', $res[1]);
@ -88,12 +80,10 @@ class CommonPasswordPolicyTest extends BaseTestCase
$this->assertSame('Password must contain at least one lowercase letter', $res[3]); $this->assertSame('Password must contain at least one lowercase letter', $res[3]);
} }
public function testValidatePasswordWithManyCharacters() public function testValidatePasswordWithManyCharacters(): void
{ {
$longPassword = str_repeat('a', 1000); $longPassword = str_repeat('a', 1000);
var_dump($longPassword); $res = $this->instance->validatePassword($longPassword);
$res = $this->object->validatePassword($longPassword);
var_dump($res);
$this->assertCount(3, $res); $this->assertCount(3, $res);
} }
} }

15
test/php/library/Icinga/Application/NoPasswordPolicyTest.php
View File

@ -8,26 +8,21 @@ use Icinga\Application\ProvidedHook\NoPasswordPolicy;
class NoPasswordPolicyTest extends BaseTestCase class NoPasswordPolicyTest extends BaseTestCase
{ {
private object $object; private PasswordPolicyHook $instance;
public function setUp(): void public function setUp(): void
{ {
$this->object = new NoPasswordPolicy(); $this->instance = new NoPasswordPolicy();
}
public function testClassIsInstanzOf()
{
$this->assertInstanceOf(PasswordPolicyHook::class, $this->object);
} }
public function testMethodGetName(): void public function testMethodGetName(): void
{ {
$this->assertSame('None', $this->object->getName()); $this->assertSame('None', $this->instance->getName());
} }
public function testValidatePasswordValid() public function testValidatePasswordValid(): void
{ {
$res = $this->object->validatePassword('icingaadmin'); $res = $this->instance->validatePassword('icingaadmin');
$this->assertEmpty($res); $this->assertEmpty($res);
} }
} }