Preferences: Rename `showBenchmark' to `show_benchmark'
We use underscore_case notation for all configuration keys. refs #4952
This commit is contained in:
parent
93829bde92
commit
a379502b15
|
@ -261,10 +261,10 @@ class GeneralForm extends Form
|
|||
|
||||
$this->addElement(
|
||||
'checkbox',
|
||||
'showBenchmark',
|
||||
'show_benchmark',
|
||||
array(
|
||||
'label' => 'Use benchmark',
|
||||
'value' => $this->getUserPreferences()->get('app.showBenchmark')
|
||||
'value' => $this->getUserPreferences()->get('app.show_benchmark')
|
||||
)
|
||||
);
|
||||
}
|
||||
|
@ -278,11 +278,11 @@ class GeneralForm extends Form
|
|||
{
|
||||
$values = $this->getValues();
|
||||
return array(
|
||||
'app.language' => $values['default_language'] ? null : $values['language'],
|
||||
'app.timezone' => $values['default_timezone'] ? null : $values['timezone'],
|
||||
'app.dateFormat' => $values['default_date_format'] ? null : $values['date_format'],
|
||||
'app.timeFormat' => $values['default_time_format'] ? null : $values['time_format'],
|
||||
'app.showBenchmark' => $values['showBenchmark'] === '1' ? true : false
|
||||
'app.language' => $values['default_language'] ? null : $values['language'],
|
||||
'app.timezone' => $values['default_timezone'] ? null : $values['timezone'],
|
||||
'app.dateFormat' => $values['default_date_format'] ? null : $values['date_format'],
|
||||
'app.timeFormat' => $values['default_time_format'] ? null : $values['time_format'],
|
||||
'app.show_benchmark' => $values['show_benchmark'] === '1' ? true : false
|
||||
);
|
||||
}
|
||||
}
|
||||
|
|
|
@ -399,9 +399,9 @@ class ActionController extends Zend_Controller_Action
|
|||
}
|
||||
|
||||
if ($user = $this->getRequest()->getUser()) {
|
||||
// Cast preference app.showBenchmark to bool because preferences loaded from a preferences storage are
|
||||
// Cast preference app.show_benchmark to bool because preferences loaded from a preferences storage are
|
||||
// always strings
|
||||
if ((bool) $user->getPreferences()->get('app.showBenchmark', false) === true) {
|
||||
if ((bool) $user->getPreferences()->get('app.show_benchmark', false) === true) {
|
||||
Benchmark::measure('Response ready');
|
||||
$layout->benchmark = $this->renderBenchmark();
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue