tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-28 00:04:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Return non-zero on display usage

Browse Source 
`Icingacli` should return non-zeno status code when display usage messages
 for example for invalid commands

https://github.com/Icinga/icinga2/issues/6585#issuecomment-418681789

It is good for automation and helps mitigate typing errors
This commit is contained in:
Max Kozlov 2018-09-05 22:16:25 +03:00 committed by GitHub
parent b3e0b5d587
commit a55e32b1a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
library/Icinga/Application/Cli.php
View File

@ -146,11 +146,12 @@ class Cli extends ApplicationBootstrap
{ {
$loader = $this->cliLoader(); $loader = $this->cliLoader();
$loader->parseParams(); $loader->parseParams();
$loader->dispatch(); $result = $loader->dispatch();
Benchmark::measure('All done'); Benchmark::measure('All done');
if ($this->showBenchmark) { if ($this->showBenchmark) {
Benchmark::dump(); Benchmark::dump();
} }
if ($result === FALSE) exit(1);
} }
protected function dispatchEndless() protected function dispatchEndless()