diff --git a/modules/monitoring/library/Monitoring/Backend/Ido/Query/HostgroupQuery.php b/modules/monitoring/library/Monitoring/Backend/Ido/Query/HostgroupQuery.php index 3dae8caf2..b783ba998 100644 --- a/modules/monitoring/library/Monitoring/Backend/Ido/Query/HostgroupQuery.php +++ b/modules/monitoring/library/Monitoring/Backend/Ido/Query/HostgroupQuery.php @@ -26,7 +26,7 @@ class HostgroupQuery extends IdoQuery ), 'hoststatus' => array( 'host_handled' => 'CASE WHEN (hs.problem_has_been_acknowledged + hs.scheduled_downtime_depth) > 0 THEN 1 ELSE 0 END', - 'host_state' => 'CASE WHEN hs.has_been_checked = 0 OR hs.has_been_checked IS NULL THEN 99 ELSE hs.current_state END' + 'host_state' => 'CASE WHEN hs.has_been_checked = 0 OR (hs.has_been_checked IS NULL AND hs.hoststatus_id IS NOT NULL) THEN 99 ELSE hs.current_state END' ), 'instances' => array( 'instance_name' => 'i.instance_name' @@ -42,7 +42,7 @@ class HostgroupQuery extends IdoQuery ), 'servicestatus' => array( 'service_handled' => 'CASE WHEN (ss.problem_has_been_acknowledged + ss.scheduled_downtime_depth + COALESCE(hs.current_state, 0)) > 0 THEN 1 ELSE 0 END', - 'service_state' => 'CASE WHEN ss.has_been_checked = 0 OR ss.has_been_checked IS NULL THEN 99 ELSE ss.current_state END' + 'service_state' => 'CASE WHEN ss.has_been_checked = 0 OR (ss.has_been_checked IS NULL AND ss.servicestatus_id IS NOT NULL) THEN 99 ELSE ss.current_state END' ) ); @@ -65,7 +65,7 @@ class HostgroupQuery extends IdoQuery protected function joinHosts() { $this->requireVirtualTable('members'); - $this->select->join( + $this->select->joinLeft( array('h' => $this->prefix . 'hosts'), 'h.host_object_id = ho.object_id', array() @@ -78,7 +78,7 @@ class HostgroupQuery extends IdoQuery protected function joinHoststatus() { $this->requireVirtualTable('members'); - $this->select->join( + $this->select->joinLeft( array('hs' => $this->prefix . 'hoststatus'), 'hs.host_object_id = ho.object_id', array() @@ -90,7 +90,7 @@ class HostgroupQuery extends IdoQuery */ protected function joinInstances() { - $this->select->join( + $this->select->joinLeft( array('i' => $this->prefix . 'instances'), 'i.instance_id = hg.instance_id', array() @@ -102,11 +102,11 @@ class HostgroupQuery extends IdoQuery */ protected function joinMembers() { - $this->select->join( + $this->select->joinLeft( array('hgm' => $this->prefix . 'hostgroup_members'), 'hgm.hostgroup_id = hg.hostgroup_id', array() - )->join( + )->joinLeft( array('ho' => $this->prefix . 'objects'), 'hgm.host_object_id = ho.object_id AND ho.is_active = 1 AND ho.objecttype_id = 1', array() @@ -119,15 +119,15 @@ class HostgroupQuery extends IdoQuery protected function joinServicegroups() { $this->requireVirtualTable('services'); - $this->select->join( + $this->select->joinLeft( array('sgm' => $this->prefix . 'servicegroup_members'), 'sgm.service_object_id = s.service_object_id', array() - )->join( + )->joinLeft( array('sg' => $this->prefix . 'servicegroups'), 'sgm.servicegroup_id = sg.servicegroup_id', array() - )->join( + )->joinLeft( array('sgo' => $this->prefix . 'objects'), 'sgo.object_id = sg.servicegroup_object_id AND sgo.is_active = 1 AND sgo.objecttype_id = 4', array() @@ -140,11 +140,11 @@ class HostgroupQuery extends IdoQuery protected function joinServices() { $this->requireVirtualTable('hosts'); - $this->select->join( + $this->select->joinLeft( array('s' => $this->prefix . 'services'), 's.host_object_id = h.host_object_id', array() - )->join( + )->joinLeft( array('so' => $this->prefix . 'objects'), 'so.object_id = s.service_object_id AND so.is_active = 1 AND so.objecttype_id = 2', array() @@ -158,7 +158,7 @@ class HostgroupQuery extends IdoQuery { $this->requireVirtualTable('services'); $this->requireVirtualTable('hoststatus'); - $this->select->join( + $this->select->joinLeft( array('ss' => $this->prefix . 'servicestatus'), 'ss.service_object_id = so.object_id', array() diff --git a/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupQuery.php b/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupQuery.php index ab5942aae..62c3577f8 100644 --- a/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupQuery.php +++ b/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupQuery.php @@ -32,7 +32,7 @@ class ServicegroupQuery extends IdoQuery ), 'servicestatus' => array( 'service_handled' => 'CASE WHEN (ss.problem_has_been_acknowledged + ss.scheduled_downtime_depth + COALESCE(hs.current_state, 0)) > 0 THEN 1 ELSE 0 END', - 'service_state' => 'CASE WHEN ss.has_been_checked = 0 OR ss.has_been_checked IS NULL THEN 99 ELSE ss.current_state END' + 'service_state' => 'CASE WHEN ss.has_been_checked = 0 OR (ss.has_been_checked IS NULL AND ss.servicestatus_id IS NOT NULL) THEN 99 ELSE ss.current_state END' ) ); @@ -55,15 +55,15 @@ class ServicegroupQuery extends IdoQuery protected function joinHostgroups() { $this->requireVirtualTable('services'); - $this->select->join( + $this->select->joinLeft( array('hgm' => $this->prefix . 'hostgroup_members'), 'hgm.host_object_id = s.host_object_id', array() - )->join( + )->joinLeft( array('hg' => $this->prefix . 'hostgroups'), 'hg.hostgroup_id = hgm.hostgroup_id', array() - )->join( + )->joinLeft( array('hgo' => $this->prefix . 'objects'), 'hgo.object_id = hg.hostgroup_object_id AND hgo.objecttype_id = 3 AND hgo.is_active = 1', array() @@ -75,7 +75,7 @@ class ServicegroupQuery extends IdoQuery */ protected function joinInstances() { - $this->select->join( + $this->select->joinLeft( array('i' => $this->prefix . 'instances'), 'i.instance_id = sg.instance_id', array() @@ -87,11 +87,11 @@ class ServicegroupQuery extends IdoQuery */ protected function joinMembers() { - $this->select->join( + $this->select->joinLeft( array('sgm' => $this->prefix . 'servicegroup_members'), 'sgm.servicegroup_id = sg.servicegroup_id', array() - )->join( + )->joinLeft( array('so' => $this->prefix . 'objects'), 'so.object_id = sgm.service_object_id AND so.objecttype_id = 2 AND so.is_active = 1', array() @@ -104,7 +104,7 @@ class ServicegroupQuery extends IdoQuery protected function joinServices() { $this->requireVirtualTable('members'); - $this->select->join( + $this->select->joinLeft( array('s' => $this->prefix . 'services'), 's.service_object_id = so.object_id', array() @@ -117,12 +117,12 @@ class ServicegroupQuery extends IdoQuery protected function joinServicestatus() { $this->requireVirtualTable('services'); - $this->select->join( + $this->select->joinLeft( array('hs' => $this->prefix . 'hoststatus'), 'hs.host_object_id = s.host_object_id', array() ); - $this->select->join( + $this->select->joinLeft( array('ss' => $this->prefix . 'servicestatus'), 'ss.service_object_id = so.object_id', array() diff --git a/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupsummaryQuery.php b/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupsummaryQuery.php index e34f8e38e..c277420a4 100644 --- a/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupsummaryQuery.php +++ b/modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicegroupsummaryQuery.php @@ -22,7 +22,7 @@ class ServicegroupsummaryQuery extends IdoQuery 'services_critical_unhandled' => 'SUM(CASE WHEN service_state = 2 AND service_handled = 0 THEN 1 ELSE 0 END)', 'services_ok' => 'SUM(CASE WHEN service_state = 0 THEN 1 ELSE 0 END)', 'services_pending' => 'SUM(CASE WHEN service_state = 99 THEN 1 ELSE 0 END)', - 'services_total' => 'SUM(1)', + 'services_total' => 'SUM(CASE WHEN service_state IS NOT NULL THEN 1 ELSE 0 END)', 'services_unknown' => 'SUM(CASE WHEN service_state = 3 THEN 1 ELSE 0 END)', 'services_unknown_handled' => 'SUM(CASE WHEN service_state = 3 AND service_handled = 1 THEN 1 ELSE 0 END)', 'services_unknown_unhandled' => 'SUM(CASE WHEN service_state = 3 AND service_handled = 0 THEN 1 ELSE 0 END)',