tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Prefer switch rather than if - elseif

This commit is contained in:
Alexander Klimov 2014-07-24 17:35:26 +02:00
parent 1902b4f10f
commit af898cc2b3
1 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
application/controllers/ConfigController.php
View File

@ -233,25 +233,29 @@ class ConfigController extends BaseConfigController
$backendType = $this->getRequest()->getParam('type'); $backendType = $this->getRequest()->getParam('type');
$authenticationConfig = IcingaConfig::app('authentication')->toArray(); $authenticationConfig = IcingaConfig::app('authentication')->toArray();
if ($backendType === 'ldap') { switch ($backendType) {
$form = new LdapBackendForm(); case 'ldap':
} else if ($backendType === 'db') { $form = new LdapBackendForm();
$form = new DbBackendForm(); break;
} else if ($backendType === 'autologin') { case 'db':
$existing = array_filter($authenticationConfig, function ($e) { return $e['backend'] === 'autologin'; }); $form = new DbBackendForm();
if (false === empty($existing)) { break;
$this->addErrorMessage( case 'autologin':
$this->translate('An autologin backend already exists') $existing = array_filter($authenticationConfig, function ($e) { return $e['backend'] === 'autologin'; });
); if (false === empty($existing)) {
$this->addErrorMessage(
$this->translate('An autologin backend already exists')
);
$this->redirectNow('config/configurationerror');
}
$form = new AutologinBackendForm();
break;
default:
$this->addErrorMessage(sprintf(
$this->translate('There is no backend type `%s\''),
$backendType
));
$this->redirectNow('config/configurationerror'); $this->redirectNow('config/configurationerror');
}
$form = new AutologinBackendForm();
} else {
$this->addErrorMessage(sprintf(
$this->translate('There is no backend type `%s\''),
$backendType
));
$this->redirectNow('config/configurationerror');
} }
$request = $this->getRequest(); $request = $this->getRequest();