Revert "Merge branch 'bugfix/Take-display_name-into-account-when-searching-for-host-and-service-names-8241'"
This reverts commit75b004dc42
, reversing changes made tobd7c7f9636
.
This commit is contained in:
parent
54207d3427
commit
b1b2e3fc21
|
@ -12,7 +12,6 @@ use Icinga\Web\Widget\Tabs;
|
||||||
use Icinga\Data\Filter\Filter;
|
use Icinga\Data\Filter\Filter;
|
||||||
use Icinga\Web\Widget;
|
use Icinga\Web\Widget;
|
||||||
use Icinga\Module\Monitoring\Forms\StatehistoryForm;
|
use Icinga\Module\Monitoring\Forms\StatehistoryForm;
|
||||||
use Icinga\Data\Filterable;
|
|
||||||
|
|
||||||
class Monitoring_ListController extends Controller
|
class Monitoring_ListController extends Controller
|
||||||
{
|
{
|
||||||
|
@ -96,7 +95,7 @@ class Monitoring_ListController extends Controller
|
||||||
'host_current_check_attempt',
|
'host_current_check_attempt',
|
||||||
'host_max_check_attempts'
|
'host_max_check_attempts'
|
||||||
), $this->addColumns()));
|
), $this->addColumns()));
|
||||||
$this->filterQuery($query, array('host', 'host_display_name'));
|
$this->filterQuery($query);
|
||||||
$this->applyRestriction('monitoring/hosts/filter', $query);
|
$this->applyRestriction('monitoring/hosts/filter', $query);
|
||||||
$this->view->hosts = $query;
|
$this->view->hosts = $query;
|
||||||
|
|
||||||
|
@ -180,7 +179,7 @@ class Monitoring_ListController extends Controller
|
||||||
'max_check_attempts' => 'service_max_check_attempts'
|
'max_check_attempts' => 'service_max_check_attempts'
|
||||||
), $this->addColumns());
|
), $this->addColumns());
|
||||||
$query = $this->backend->select()->from('serviceStatus', $columns);
|
$query = $this->backend->select()->from('serviceStatus', $columns);
|
||||||
$this->filterQuery($query, array('service', 'service_display_name'));
|
$this->filterQuery($query);
|
||||||
$this->applyRestriction('monitoring/services/filter', $query);
|
$this->applyRestriction('monitoring/services/filter', $query);
|
||||||
$this->view->services = $query;
|
$this->view->services = $query;
|
||||||
|
|
||||||
|
@ -498,7 +497,7 @@ class Monitoring_ListController extends Controller
|
||||||
))->order('services_severity')->order('servicegroup_alias');
|
))->order('services_severity')->order('servicegroup_alias');
|
||||||
// TODO(el): Can't default to the sort rules of the data view because it's meant for both host groups and
|
// TODO(el): Can't default to the sort rules of the data view because it's meant for both host groups and
|
||||||
// service groups. We should separate them.
|
// service groups. We should separate them.
|
||||||
$this->filterQuery($query, array('servicegroup', 'servicegroup_alias'));
|
$this->filterQuery($query);
|
||||||
$this->view->servicegroups = $query;
|
$this->view->servicegroups = $query;
|
||||||
|
|
||||||
$this->setupLimitControl();
|
$this->setupLimitControl();
|
||||||
|
@ -556,7 +555,7 @@ class Monitoring_ListController extends Controller
|
||||||
))->order('services_severity')->order('hostgroup_alias');
|
))->order('services_severity')->order('hostgroup_alias');
|
||||||
// TODO(el): Can't default to the sort rules of the data view because it's meant for both host groups and
|
// TODO(el): Can't default to the sort rules of the data view because it's meant for both host groups and
|
||||||
// service groups. We should separate them.
|
// service groups. We should separate them.
|
||||||
$this->filterQuery($query, array('hostgroup', 'hostgroup_alias'));
|
$this->filterQuery($query);
|
||||||
$this->view->hostgroups = $query;
|
$this->view->hostgroups = $query;
|
||||||
|
|
||||||
$this->setupLimitControl();
|
$this->setupLimitControl();
|
||||||
|
@ -627,15 +626,7 @@ class Monitoring_ListController extends Controller
|
||||||
$this->view->verticalPaginator = $pivot->paginateYAxis();
|
$this->view->verticalPaginator = $pivot->paginateYAxis();
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
protected function filterQuery($query)
|
||||||
* Apply filters on a query
|
|
||||||
*
|
|
||||||
* @param Filterable $query The query to apply filters on
|
|
||||||
* @param array $searchColumns Columns to search in
|
|
||||||
*
|
|
||||||
* @return Filterable $query
|
|
||||||
*/
|
|
||||||
protected function filterQuery(Filterable $query, array $searchColumns = null)
|
|
||||||
{
|
{
|
||||||
$editor = Widget::create('filterEditor')
|
$editor = Widget::create('filterEditor')
|
||||||
->setQuery($query)
|
->setQuery($query)
|
||||||
|
@ -643,11 +634,8 @@ class Monitoring_ListController extends Controller
|
||||||
'limit', 'sort', 'dir', 'format', 'view', 'backend',
|
'limit', 'sort', 'dir', 'format', 'view', 'backend',
|
||||||
'stateType', 'addColumns', '_dev'
|
'stateType', 'addColumns', '_dev'
|
||||||
)
|
)
|
||||||
->ignoreParams('page');
|
->ignoreParams('page')
|
||||||
if ($searchColumns !== null) {
|
->handleRequest($this->getRequest());
|
||||||
$editor->setSearchColumns($searchColumns);
|
|
||||||
}
|
|
||||||
$editor->handleRequest($this->getRequest());
|
|
||||||
$query->applyFilter($editor->getFilter());
|
$query->applyFilter($editor->getFilter());
|
||||||
|
|
||||||
$this->setupFilterControl($editor);
|
$this->setupFilterControl($editor);
|
||||||
|
|
Loading…
Reference in New Issue