From bf33c9c13b50c761bd6948847514b3ae110a9c11 Mon Sep 17 00:00:00 2001
From: Eric Lippmann <eric.lippmann@netways.de>
Date: Thu, 20 Nov 2014 16:12:02 +0100
Subject: [PATCH] Permissions: Show restrictions in the permissions list

---
 .../views/scripts/permissions/index.phtml     | 24 ++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/application/views/scripts/permissions/index.phtml b/application/views/scripts/permissions/index.phtml
index 07ab6d30d..3dd11cc81 100644
--- a/application/views/scripts/permissions/index.phtml
+++ b/application/views/scripts/permissions/index.phtml
@@ -12,6 +12,7 @@
                 <tr>
                     <th><?= $this->translate('Name') ?></th>
                     <th><?= $this->translate('Permissions') ?></th>
+                    <th><?= $this->translate('Restrictions') ?></th>
                     <th><?= $this->translate('Users') ?></th>
                     <th><?= $this->translate('Groups') ?></th>
                 </tr>
@@ -25,7 +26,28 @@
                                 <a href="<?= $this->url('permissions/update', array('role' => $name)) ?>"></a>
                             </div>
                         </td>
-                        <td><?= $this->escape($role->permissions) ?></td>
+                        <td><?= $this->escape($role->permissions, 0, 50) ?></td>
+                        <td>
+                            <?php
+                            // TODO(el): $role->without(...) or $role->shift(...) would be nice!
+                            $restrictions = $role;
+                            unset($restrictions['users']);
+                            unset($restrictions['groups']);
+                            unset($restrictions['permissions']);
+                            ?>
+                            <?php if (! empty($restrictions)): ?>
+                            <table>
+                                <tbody>
+                                <?php foreach ($restrictions as $restrictionName => $restriction): ?>
+                                    <tr>
+                                        <th><?= $this->escape($restrictionName) ?></th>
+                                        <td><?= $this->escape($restriction) ?></td>
+                                    </tr>
+                                <?php endforeach ?>
+                                </tbody>
+                            </table>
+                            <?php endif ?>
+                        </td>
                         <td><?= $this->escape($role->users) ?></td>
                         <td><?= $this->escape($role->groups) ?></td>
                         <td>