From c41160405d886c338e99c2e331a11c6c079a5cac Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Sat, 8 Mar 2014 19:49:57 +0100
Subject: [PATCH] Dedicated view script for object actions

---
 .../scripts/show/components/actions.phtml     | 39 +++++++++++++++++++
 .../scripts/show/components/status.phtml      | 37 ------------------
 2 files changed, 39 insertions(+), 37 deletions(-)
 create mode 100644 modules/monitoring/application/views/scripts/show/components/actions.phtml

diff --git a/modules/monitoring/application/views/scripts/show/components/actions.phtml b/modules/monitoring/application/views/scripts/show/components/actions.phtml
new file mode 100644
index 000000000..9f3211bd3
--- /dev/null
+++ b/modules/monitoring/application/views/scripts/show/components/actions.phtml
@@ -0,0 +1,39 @@
+<?php
+
+if (! $object->action_url && ! $object->notes_url) {
+    return;
+}
+
+$links = array();
+$linkText = '<a href="%s" target="_blank">%s</a>';
+
+if ($object->notes_url) {
+    if (strpos($object->notes_url, "' ") === false) {
+        $links[] = sprintf($linkText, $this->resolveMacros($object->notes_url, $object), 'Notes');
+    } else {
+        // TODO: We should find out document what's going on here. Looks strange :p
+        foreach(explode("' ", $object->notes_url) as $url) {
+            $url = strpos($url, "'") === 0 ? substr($url, 1) : $url;
+            $url = strrpos($url, "'") === strlen($url) - 1 ? substr($url, 0, strlen($url) - 1) : $url;
+            $links[] = sprintf($linkText, $this->resolveMacros($url, $object), 'Notes');
+        }
+    }
+}
+if ($object->action_url) {
+    if (strpos($object->action_url, "' ") === false) {
+        $links[] = sprintf($linkText, $this->resolveMacros($object->action_url, $object), 'Action');
+    } else {
+        // TODO: We should find out document what's going on here. Looks strange :p
+        foreach(explode("' ", $object->action_url) as $url) {
+            $url = strpos($url, "'") === 0 ? substr($url, 1) : $url;
+            $url = strrpos($url, "'") === strlen($url) - 1 ? substr($url, 0, strlen($url) - 1) : $url;
+            $links[] = sprintf($linkText, $this->resolveMacros($url, $object), 'Action');
+        }
+    }
+}
+
+?>
+<tr>
+  <th>Foreign URLs</th>
+  <td><?= implode("\n ", $links) . "\n" ?></td>
+</tr>
diff --git a/modules/monitoring/application/views/scripts/show/components/status.phtml b/modules/monitoring/application/views/scripts/show/components/status.phtml
index d1b69f230..458c08c8b 100644
--- a/modules/monitoring/application/views/scripts/show/components/status.phtml
+++ b/modules/monitoring/application/views/scripts/show/components/status.phtml
@@ -14,43 +14,6 @@
     }
 ?>
 <div>
-    <div class="panel-heading border-status-<?= $objectStateName ?>">
-        <div class="panel-hostname">
-
-
-            <div class="small-row">
-
-                <?php if ($object->action_url || $object->notes_url): ?>
-                        <br />
-                        <?php if ($object->notes_url): ?>
-                            <?php if (strpos($object->notes_url, "' ") === false): ?>
-                                <a target="_new" href='<?= $this->escape($this->resolveMacros($object->notes_url, $object)); ?>'>Notes</a>
-                            <?php else: ?>
-                                <?php foreach(explode("' ", $object->notes_url) as $url): ?>
-                                    <?php $url = strpos($url, "'") === 0 ? substr($url, 1) : $url; ?>
-                                    <?php $url = strrpos($url, "'") === strlen($url) - 1 ? substr($url, 0, strlen($url) - 1) : $url; ?>
-                                    <a target="_new" href='<?= $this->escape($this->resolveMacros($url, $object)); ?>'>Notes</a>
-                                <?php endforeach; ?>
-                            <?php endif; ?>
-                        <?php endif; ?>
-                        <?php if ($object->action_url): ?>
-                            <?php if (strpos($object->action_url, "' ") === false): ?>
-                                <a target="_new" href='<?= $this->escape($this->resolveMacros($this->object->action_url, $object)); ?>'>Action</a>
-                            <?php else: ?>
-                                <?php foreach(explode("' ", $object->action_url) as $url): ?>
-                                    <?php $url = strpos($url, "'") === 0 ? substr($url, 1) : $url; ?>
-                                    <?php $url = strrpos($url, "'") === strlen($url) - 1 ? substr($url, 0, strlen($url) - 1) : $url; ?>
-                                    <a target="_new" href='<?= $this->escape($this->resolveMacros($url, $object)); ?>'>Action</a>
-                                <?php endforeach; ?>
-                            <?php endif; ?>
-                        <?php endif; ?>
-                <?php endif; ?>
-            </div>
-        </div>
-    </div>
-
-    <hr class="separator" />
-
     <div class="panel-body">
 
         <div class="panel-row">