tests: Add :void return type declarations

This commit is contained in:
Johannes Meyer 2021-04-09 09:39:10 +02:00
parent 19a092c13f
commit cb87190138
17 changed files with 23 additions and 23 deletions

View File

@ -138,7 +138,7 @@ namespace Icinga\Test {
/**
* Setup MVC bootstrapping and ensure that the Icinga-Mock gets reinitialized
*/
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->setupIcingaMock();

View File

@ -20,7 +20,7 @@ class PluginOutputTest extends BaseTestCase
protected static $statusTags = array('OK', 'WARNING', 'CRITICAL', 'UNKNOWN', 'UP', 'DOWN');
public function setUp()
public function setUp(): void
{
parent::setUp();

View File

@ -24,7 +24,7 @@ class ConfigWithSetModuleConfig extends Config
class Bug7043Test extends BaseTestCase
{
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
Mockery::close(); // Necessary because some tests run in a separate process

View File

@ -12,7 +12,7 @@ require_once BaseTestCase::$appDir . '/views/helpers/DateFormat.php';
class DateFormatTest extends BaseTestCase
{
public function tearDown()
public function tearDown(): void
{
DateTimeFactory::setConfig(array('timezone' => date_default_timezone_get()));
}

View File

@ -26,7 +26,7 @@ class TestStruct
EOD;
public function setUp()
public function setUp(): void
{
parent::setUp();
$tempDir = sys_get_temp_dir();
@ -35,7 +35,7 @@ EOD;
file_put_contents($this->baseDir. self::$classFile, self::$classContent);
}
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
system('rm -rf '. $this->baseDir);

View File

@ -11,7 +11,7 @@ class ConfigTest extends BaseTestCase
/**
* Set up config dir
*/
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->oldConfigDir = Config::$configDir;
@ -21,7 +21,7 @@ class ConfigTest extends BaseTestCase
/**
* Reset config dir
*/
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
Config::$configDir = $this->oldConfigDir;

View File

@ -10,7 +10,7 @@ class ArrayDatasourceTest extends BaseTestCase
{
private $sampleData;
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->sampleData = array(

View File

@ -61,7 +61,7 @@ class FilterTest extends BaseTestCase
private $sampleData;
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->sampleData = array(

View File

@ -12,13 +12,13 @@ class IniParserTest extends BaseTestCase
{
protected $tempFile;
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->tempFile = tempnam(sys_get_temp_dir(), 'icinga-ini-parser-test');
}
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
unlink($this->tempFile);

View File

@ -12,7 +12,7 @@ class IniWriterTest extends BaseTestCase
protected $tempFile;
protected $tempFile2;
public function setUp()
public function setUp(): void
{
parent::setUp();
@ -20,7 +20,7 @@ class IniWriterTest extends BaseTestCase
$this->tempFile2 = tempnam(sys_get_temp_dir(), 'icinga-ini-writer-test-2');
}
public function tearDown()
public function tearDown(): void
{
parent::tearDown();

View File

@ -10,14 +10,14 @@ use Icinga\Test\BaseTestCase;
class StreamWriterTest extends BaseTestCase
{
public function setUp()
public function setUp(): void
{
parent::setUp();
$this->target = tempnam(sys_get_temp_dir(), 'log');
}
public function tearDown()
public function tearDown(): void
{
parent::tearDown();

View File

@ -10,7 +10,7 @@ class BaseTestCaseTest extends BaseTestCase
{
protected $emptySqlDumpFile;
public function tearDown()
public function tearDown(): void
{
parent::tearDown();

View File

@ -17,7 +17,7 @@ class TranslatorWithHardcodedLocaleCodes extends Translator
class TranslatorTest extends BaseTestCase
{
public function setUp()
public function setUp(): void
{
parent::setUp();
Translator::registerDomain('icingatest', BaseTestCase::$testDir . '/res/locale');

View File

@ -26,7 +26,7 @@ class SuccessfulForm extends Form
class FormTest extends BaseTestCase
{
public function tearDown()
public function tearDown(): void
{
Mockery::close(); // Necessary as some tests are running isolated
}

View File

@ -41,14 +41,14 @@ class HookTest extends BaseTestCase
protected $failingHook = '\\Tests\\Icinga\\Web\\FailingHook';
protected $testBaseClass = '\\Icinga\\Web\\Hook\\TestHook';
public function setUp()
public function setUp(): void
{
$this->markTestSkipped();
parent::setUp();
Hook::clean();
}
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
Hook::clean();

View File

@ -39,7 +39,7 @@ class DashboardWithPredefinableActiveName extends Dashboard
class DashboardTest extends BaseTestCase
{
public function tearDown()
public function tearDown(): void
{
parent::tearDown();
Mockery::close(); // Necessary because some tests run in a separate process

View File

@ -11,7 +11,7 @@ use Icinga\Web\Widget\SearchDashboard;
class SearchDashboardTest extends BaseTestCase
{
public function setUp()
public function setUp(): void
{
$moduleMock = Mockery::mock('Icinga\Application\Modules\Module');
$searchUrl = (object) array(