tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Introduce Form::setOnSuccess() in favor of overriding the constructor 

Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
This commit is contained in:
Eric Lippmann 2014-11-04 16:15:06 +01:00
parent 0f48382f69
commit d2eddcbec6
1 changed files with 10 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
library/Icinga/Web/Form.php
View File

@ -108,30 +108,23 @@ class Form extends Zend_Form
); );
/** /**
* Create a new form * Set a callback that is called instead of this form's onSuccess method
* *
* Accepts an additional option `onSuccess' which is a callback that is called instead of this * It is called using the following signature: (Request $request, Form $form).
* form's method. It is called using the following signature: (Request $request, Form $form).
* *
* @see Zend_Form::__construct() * @param callable $onSuccess Callback
* *
* @throws LogicException In case `onSuccess' is not callable * @return $this
*
* @throws LogicException If the callback is not callable
*/ */
public function __construct($options = null) public function setOnSuccess($onSuccess)
{ {
if (is_array($options) && isset($options['onSuccess'])) { if (! is_callable($onSuccess)) {
$this->onSuccess = $options['onSuccess'];
unset($options['onSuccess']);
} elseif (isset($options->onSuccess)) {
$this->onSuccess = $options->onSuccess;
unset($options->onSuccess);
}
if ($this->onSuccess !== null && false === is_callable($this->onSuccess)) {
throw new LogicException('The option `onSuccess\' is not callable'); throw new LogicException('The option `onSuccess\' is not callable');
} }
$this->onSuccess = $onSuccess;
parent::__construct($options); return $this;
} }
/** /**