From e6ded2eb3c6fab97f60a9c440238d22f8321ecf3 Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Sat, 15 Nov 2014 23:39:21 +0100 Subject: [PATCH] FilterEditor: use new id helper in selectSign --- library/Icinga/Web/Widget/FilterEditor.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/library/Icinga/Web/Widget/FilterEditor.php b/library/Icinga/Web/Widget/FilterEditor.php index 9f8848204..51738d86d 100644 --- a/library/Icinga/Web/Widget/FilterEditor.php +++ b/library/Icinga/Web/Widget/FilterEditor.php @@ -337,9 +337,8 @@ class FilterEditor extends AbstractWidget ); } - protected function selectSign($filter) + protected function selectSign(Filter $filter = null) { - $name = 'sign_' . $filter->getId(); $signs = array( '=' => '=', '!=' => '!=', @@ -350,9 +349,9 @@ class FilterEditor extends AbstractWidget ); return $this->select( - $name, + $this->elementId('sign', $filter), $signs, - $filter->getSign(), + $filter === null ? null : $filter->getSign(), array('style' => 'width: 4em') ); }