tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DataView: Relax filter validation again 

There are way too much missing columns in data views all
over the place. I dont' see a justification to fix them
as it's only now this "issue" occurs. It's easier to
revert this change here.

fixes #4797
This commit is contained in:
Johannes Meyer 2022-06-14 14:56:33 +02:00
parent c65ba3c2fc
commit ec27f77861
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/monitoring/library/Monitoring/DataView/DataView.php
View File

@ -4,6 +4,7 @@
namespace Icinga\Module\Monitoring\DataView; namespace Icinga\Module\Monitoring\DataView;
use Icinga\Data\Filter\FilterExpression; use Icinga\Data\Filter\FilterExpression;
use Icinga\Data\Filter\FilterMatch;
use IteratorAggregate; use IteratorAggregate;
use Icinga\Application\Hook; use Icinga\Application\Hook;
use Icinga\Data\ConnectionInterface; use Icinga\Data\ConnectionInterface;
@ -402,7 +403,7 @@ abstract class DataView implements QueryInterface, SortRules, FilterColumns, Ite
*/ */
public function validateFilterColumns(Filter $filter) public function validateFilterColumns(Filter $filter)
{ {
if ($filter instanceof FilterExpression) { if ($filter instanceof FilterMatch) {
if (! $this->isValidFilterTarget($filter->getColumn())) { if (! $this->isValidFilterTarget($filter->getColumn())) {
throw new QueryException( throw new QueryException(
mt('monitoring', 'The filter column "%s" is not allowed here.'), mt('monitoring', 'The filter column "%s" is not allowed here.'),