tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't use printf format strings as array keys 

An array with printf format strings as keys looks pretty ugly
This commit is contained in:
Alexander Klimov 2014-07-17 11:26:18 +02:00
parent 4d199180b3
commit eca0d50bae
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
modules/monitoring/application/views/scripts/list/contacts.phtml
View File

@ -26,15 +26,26 @@ $contactHelper = $this->getHelper('ContactFlags');
) ?>"><strong><?= $contact->contact_name ?></strong></a> (<?= $contact->contact_alias ?>)
<?php
foreach (array(
'eMail: <a href="mailto:%1$s">%1$s</a>' => $contact->contact_email,
'Pager: %s' => $contact->contact_pager,
'Service notification period: %s' => $contact->contact_notify_service_timeperiod,
'Host notification period: %s' => $contact->contact_notify_host_timeperiod
) as $format => $value):
'eMail' => array(
$contact->contact_email, '<a href="mailto:%1$s">%1$s</a>'
),
'Pager' => $contact->contact_pager,
'Service notification period' => $contact->contact_notify_service_timeperiod,
'Host notification period' => $contact->contact_notify_host_timeperiod
) as $key => $value):
if (is_string($value)) {
$format = '%s';
} else {
$format = $value[1];
$value = $value[0];
}
if ($value): ?>
<br />
<?php
printf($format, htmlspecialchars($value));
printf(
'%s: %s', $key,
sprintf($format, htmlspecialchars($value))
);
endif;
endforeach;
?>