Simplify InternalUrlValidator::isValid()

refs #11920
2016-09-09 15:22:24 +02:00 · 2016-09-09 15:22:24 +02:00 · ef7be98e0c
parent 1f980f92f2
commit ef7be98e0c
1 changed files with 5 additions and 3 deletions
--- a/library/Icinga/Web/Form/Validator/InternalUrlValidator.php
+++ b/library/Icinga/Web/Form/Validator/InternalUrlValidator.php
@ -16,11 +16,13 @@ class InternalUrlValidator extends Zend_Validate_Abstract
     */
    public function isValid($value)
    {
-        $isExternal = Url::fromPath($value)->isExternal();
-        if ($isExternal) {
+        if (Url::fromPath($value)->isExternal()) {
            $this->_error('IS_EXTERNAL');
+
+            return false;
        }
-        return ! $isExternal;
+
+        return true;
    }

    /**