From f31e697d72ccd3c3964d47ceae91d1de57f688bd Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Sun, 9 Mar 2014 00:58:49 +0100
Subject: [PATCH] Handle _blank and similar links in JS as 'return true' seems
 unreliable

---
 public/js/icinga/events.js | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/public/js/icinga/events.js b/public/js/icinga/events.js
index dd9a16293..a9b350e94 100644
--- a/public/js/icinga/events.js
+++ b/public/js/icinga/events.js
@@ -155,20 +155,22 @@
         linkClicked: function (event) {
             var self   = event.data.self;
             var icinga = self.icinga;
-
             var $a = $(this);
             var href = $a.attr('href');
+            var linkTarget = $a.attr('target');
             var $li;
             var $target;
             var isMenuLink = $a.closest('#menu').length > 0;
 
             // TODO: Let remote links pass through. Right now they only work
             //       combined with target="_blank" or target="_self"
-            if ($a.attr('target') === '_blank' || $a.attr('target') === '_self') {
-                return true;
+            // window.open is used as return true; didn't work reliable
+            if (linkTarget === '_blank' || linkTarget === '_self') {
+                window.open(href, linkTarget);
+                return false;
             }
 
-            // All other links are handled as XHR requests
+            // Handle all other links as XHR requests
             event.stopPropagation();
             event.preventDefault();