tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-04-08 17:15:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Check the correct return type in case preg_replace fails in ExternalBackend.php

Browse Source
This commit is contained in:
Eric Lippmann 2016-11-16 14:10:31 +01:00
parent 63bf9e20cd
commit f7e5cd3b71
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/Icinga/Authentication/User/ExternalBackend.php
View File

@ -83,7 +83,7 @@ class ExternalBackend implements UserBackendInterface
if ($this->stripUsernameRegexp) { if ($this->stripUsernameRegexp) {
$stripped = preg_replace($this->stripUsernameRegexp, '', $username); $stripped = preg_replace($this->stripUsernameRegexp, '', $username);
if ($stripped !== false) { if ($stripped !== null) {
// TODO(el): PHP issues a warning when PHP cannot compile the regular expression. Should we log an // TODO(el): PHP issues a warning when PHP cannot compile the regular expression. Should we log an
// additional message in that case? // additional message in that case?
$username = $stripped; $username = $stripped;