tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DbMigrationStep: Don't cache sql statements unnecessarily

This commit is contained in:
Yonas Habteab 2023-09-15 11:17:05 +02:00 committed by Johannes Meyer
parent 864a78302f
commit fac3855a86
1 changed files with 15 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
library/Icinga/Application/Hook/Common/DbMigrationStep.php
View File

@ -9,9 +9,6 @@ use RuntimeException;
class DbMigrationStep class DbMigrationStep
{ {
/** @var string The sql string to be executed */
protected $query;
/** @var string The sql script version the queries are loaded from */ /** @var string The sql script version the queries are loaded from */
protected $version; protected $version;
@ -109,27 +106,23 @@ class DbMigrationStep
*/ */
public function apply(Connection $conn): self public function apply(Connection $conn): self
{ {
if (! $this->query) { $statements = @file_get_contents($this->getScriptPath());
$statements = @file_get_contents($this->getScriptPath()); if ($statements === false) {
if ($statements === false) { throw new RuntimeException(sprintf('Cannot load upgrade script %s', $this->getScriptPath()));
throw new RuntimeException(sprintf('Cannot load upgrade script %s', $this->getScriptPath()));
}
if (empty($statements)) {
throw new RuntimeException('Nothing to migrate');
}
if (preg_match('/\s*delimiter\s*(\S+)\s*$/im', $statements, $matches)) {
/** @var string $statements */
$statements = preg_replace('/\s*delimiter\s*(\S+)\s*$/im', '', $statements);
/** @var string $statements */
$statements = preg_replace('/' . preg_quote($matches[1], '/') . '$/m', ';', $statements);
}
$this->query = $statements;
} }
$conn->exec($this->query); if (empty($statements)) {
throw new RuntimeException('Nothing to migrate');
}
if (preg_match('/\s*delimiter\s*(\S+)\s*$/im', $statements, $matches)) {
/** @var string $statements */
$statements = preg_replace('/\s*delimiter\s*(\S+)\s*$/im', '', $statements);
/** @var string $statements */
$statements = preg_replace('/' . preg_quote($matches[1], '/') . '$/m', ';', $statements);
}
$conn->exec($statements);
return $this; return $this;
} }