tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-25 23:04:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix class loading to not rely on the longest namespace match

Browse Source 
refs #5786
This commit is contained in:
Eric Lippmann 2015-08-18 10:50:29 +02:00
parent 234dc951d2
commit fae2e0979a
1 changed files with 28 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
library/Icinga/Application/ClassLoader.php
View File

@ -3,8 +3,6 @@
namespace Icinga\Application; namespace Icinga\Application;
use Icinga\Exception\ProgrammingError;
/** /**
* PSR-4 class loader * PSR-4 class loader
*/ */
@ -49,6 +47,30 @@ class ClassLoader
return array_key_exists($namespace, $this->namespaces); return array_key_exists($namespace, $this->namespaces);
} }
/**
* Get the source file of the given class or interface
*
* @param string $class Name of the class or interface
*
* @return string|null
*/
public function getSourceFile($class)
{
foreach ($this->namespaces as $namespace => $dir) {
if ($class === strstr($class, $namespace)) {
$classPath = str_replace(
self::NAMESPACE_SEPARATOR,
DIRECTORY_SEPARATOR,
substr($class, strlen($namespace))
) . '.php';
if (file_exists($file = $dir . $classPath)) {
return $file;
}
}
}
return null;
}
/** /**
* Load the given class or interface * Load the given class or interface
* *
@ -58,50 +80,10 @@ class ClassLoader
*/ */
public function loadClass($class) public function loadClass($class)
{ {
$namespace = $this->getNamespaceForClass($class); if ($file = $this->getSourceFile($class)) {
require $file;
if ($namespace) { return true;
$file = $this->namespaces[$namespace] . preg_replace('/^' . preg_quote($namespace) . '/', '', $class);
$file = str_replace(self::NAMESPACE_SEPARATOR, '/', $file) . '.php';
if (@file_exists($file)) {
require_once $file;
return true;
}
} }
return false;
}
/**
* Get the namespace for the given class
*
* Return is the longest match in the array found
*
* @param string $className
*
* @return bool|string
*/
private function getNamespaceForClass($className)
{
$testNamespace = '';
$testLength = 0;
foreach (array_keys($this->namespaces) as $namespace) {
$stub = preg_replace(
'/^' . preg_quote($namespace) . '(' . preg_quote(self::NAMESPACE_SEPARATOR) . '|$)/', '', $className
);
$length = strlen($className) - strlen($stub);
if ($length > $testLength) {
$testLength = $length;
$testNamespace = $namespace;
}
}
if ($testLength > 0) {
return $testNamespace;
}
return false; return false;
} }
@ -122,7 +104,7 @@ class ClassLoader
} }
/** /**
* Unregister this as an autloader * Unregister this as an autoloader
*/ */
public function __destruct() public function __destruct()
{ {