From fb33a2097a58fcb23ed4addfb4d4aa56106c3481 Mon Sep 17 00:00:00 2001 From: Yonas Habteab Date: Mon, 11 Sep 2023 15:06:25 +0200 Subject: [PATCH] Defferentiate migrations with no provided descriptions --- library/Icinga/Web/Widget/ItemList/MigrationListItem.php | 3 +++ .../Web/Widget/ItemList/MigrationListItemMinimal.php | 7 ++++++- public/css/icinga/pending-migration.less | 4 ++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/library/Icinga/Web/Widget/ItemList/MigrationListItem.php b/library/Icinga/Web/Widget/ItemList/MigrationListItem.php index 80ba930d5..d75d179d6 100644 --- a/library/Icinga/Web/Widget/ItemList/MigrationListItem.php +++ b/library/Icinga/Web/Widget/ItemList/MigrationListItem.php @@ -62,6 +62,9 @@ class MigrationListItem extends BaseListItem { if ($this->item->getDescription()) { $caption->addHtml(Text::create($this->item->getDescription())); + } else { + $caption->getAttributes()->add('class', 'empty-state'); + $caption->addHtml(Text::create($this->translate('No description provided.'))); } } diff --git a/library/Icinga/Web/Widget/ItemList/MigrationListItemMinimal.php b/library/Icinga/Web/Widget/ItemList/MigrationListItemMinimal.php index 7602b5947..616c06d40 100644 --- a/library/Icinga/Web/Widget/ItemList/MigrationListItemMinimal.php +++ b/library/Icinga/Web/Widget/ItemList/MigrationListItemMinimal.php @@ -71,7 +71,12 @@ class MigrationListItemMinimal extends BaseListItem /** @var DbMigration $migration */ $migration = array_shift($migrations); if ($migration->getLastState()) { - $caption->addHtml(Text::create($migration->getDescription())); + if ($migration->getDescription()) { + $caption->addHtml(Text::create($migration->getDescription())); + } else { + $caption->getAttributes()->add('class', 'empty-state'); + $caption->addHtml(Text::create($this->translate('No description provided.'))); + } $wrapper = new HtmlElement( 'div', diff --git a/public/css/icinga/pending-migration.less b/public/css/icinga/pending-migration.less index 8c574c9f5..581a888fc 100644 --- a/public/css/icinga/pending-migration.less +++ b/public/css/icinga/pending-migration.less @@ -18,6 +18,10 @@ .visual.upgrade-failed, span.upgrade-failed, .errors-section > i { color: @state-critical; } + + .caption.empty-state { + color: @gray-semilight; + } } .migration-form {