Make use if 'ignore´ instead of explicitly unsetting array keys

refs #5525

application/forms/Authentication/LoginForm.php

@@ -57,6 +57,7 @@ class LoginForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Login')
             )
         );

application/forms/Config/Authentication/BaseBackendForm.php

@@ -20,6 +20,7 @@ abstract class BaseBackendForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );
@@ -75,9 +76,6 @@ abstract class BaseBackendForm extends Form
         $values = $this->getValues();
         $name = $values['name'];
         unset($values['name']);
-        unset($values['btn_submit']);
-        unset($values['force_creation']);
-        unset($values[$this->getTokenElementName()]);
         return array($name, $values);
     }
 
@@ -104,6 +102,7 @@ abstract class BaseBackendForm extends Form
             'force_creation',
             array(
                 'order'     => 0,
+                'ignore'    => true,
                 'label'     => t('Force Changes'),
                 'helptext'  => t('Check this box to enforce changes without connectivity validation')
             )

application/forms/Config/ConfirmRemovalForm.php

@@ -28,6 +28,7 @@ class ConfirmRemovalForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Confirm Removal')
             )
         );

application/forms/Config/GeneralForm.php

@@ -46,6 +46,7 @@ class GeneralForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );

application/forms/Config/LoggingForm.php

@@ -134,6 +134,7 @@ class LoggingForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save')
             )
         );
@@ -141,21 +142,6 @@ class LoggingForm extends Form
         return $this;
     }
 
-    /**
-     * Retrieve all form element values
-     *
-     * Returns all configuration relevant element values.
-     *
-     * @return  array
-     */
-    public function getValues()
-    {
-        $values = parent::getValues();
-        unset($values['btn_submit']);
-        unset($values[$this->getTokenElementName()]);
-        return $values;
-    }
-
     /**
      * Return the default logging directory for type "file"
      *

application/forms/Config/ResourceForm.php

@@ -83,6 +83,7 @@ class ResourceForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );
@@ -197,9 +198,6 @@ class ResourceForm extends Form
         $values = $this->getValues();
         $name = $values['name'];
         unset($values['name']);
-        unset($values['btn_submit']);
-        unset($values['force_creation']);
-        unset($values[$this->getTokenElementName()]);
         return array($name, $values);
     }
 
@@ -228,6 +226,7 @@ class ResourceForm extends Form
             'force_creation',
             array(
                 'order'     => 0,
+                'ignore'    => true,
                 'label'     => t('Force Changes'),
                 'helptext'  => t('Check this box to enforce changes without connectivity validation')
             )

application/forms/Dashboard/AddUrlForm.php

@@ -56,6 +56,7 @@ class AddUrlForm extends Form
                     'submit',
                     'use_existing_dashboard',
                     array(
+                        'ignore'    => true,
                         'label'     => t('Use An Existing Pane'),
                         'style'     => 'display: inline-block'
                     )
@@ -76,6 +77,7 @@ class AddUrlForm extends Form
                 'submit',
                 'create_new_pane',
                 array(
+                    'ignore'    => true,
                     'label'     => t('Create A New Pane'),
                     'style'     => 'display: inline-block'
                 )
@@ -103,6 +105,7 @@ class AddUrlForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Add To Dashboard')
             )
         );

application/forms/Preference/GeneralForm.php

@@ -138,6 +138,7 @@ class GeneralForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );

library/Icinga/Web/Form.php

@@ -216,6 +216,7 @@ class Form extends Zend_Form
                 'hidden',
                 $this->tokenElementName,
                 array(
+                    'ignore'    => true,
                     'value'     => $this->generateCsrfToken()
                 )
             );

modules/monitoring/application/forms/Config/BackendForm.php

@@ -74,6 +74,7 @@ class BackendForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );
@@ -98,8 +99,6 @@ class BackendForm extends Form
         }
 
         unset($values['name']);
-        unset($values['btn_submit']);
-        unset($values[$this->getTokenElementName()]);
         return array($name, $values);
     }
 

modules/monitoring/application/forms/Config/InstanceForm.php

@@ -33,6 +33,7 @@ class InstanceForm extends Form
                 'type',
                 array(
                     'required'      => true,
+                    'ignore'        => true,
                     'label'         => t('Instance Type'),
                     'class'         => 'autosubmit',
                     'helptext'      => t(
@@ -92,6 +93,7 @@ class InstanceForm extends Form
                 'hitchhiker',
                 array(
                     'required'  => true,
+                    'ignore'    => true,
                     'value'     => 'Arthur'
                 )
             );
@@ -119,6 +121,7 @@ class InstanceForm extends Form
             'submit',
             'btn_submit',
             array(
+                'ignore'    => true,
                 'label'     => t('Save Changes')
             )
         );
@@ -138,10 +141,6 @@ class InstanceForm extends Form
         $values = $this->getValues();
         $name = $values['name'];
         unset($values['name']);
-        unset($values['type']);
-        unset($values['hitchhiker']);
-        unset($values['btn_submit']);
-        unset($values[$this->getTokenElementName()]);
         return array($name, $values);
     }