tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-05 13:04:27 +02:00
Code Issues Packages Projects Releases Wiki Activity
13,960 Commits 126 Branches 75 Tags
Commit Graph

4217 Commits

Author SHA1 Message Date
Johannes Meyer
fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-29 16:05:56 +02:00
Johannes Meyer
e020dd3541 Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath 
Prior to this change it was not possible to create an instance of Config
without passing a config file.
 2014-08-29 12:23:48 +02:00
Johannes Meyer
79b0ed64ec Make it possible to provide a closure to be called instead of onSuccess() 
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.

refs #5525
 2014-08-29 12:21:31 +02:00
Johannes Meyer
bf23688e73 Make autosubmit work in non-JS enviroments 
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.

refs #5525
 2014-08-29 09:08:53 +02:00
Johannes Meyer
486104d59e Check explictly for FALSE when calling onSuccess() 
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.

refs #5525
 2014-08-29 09:04:20 +02:00
Matthias Jentsch
3642b7b6fc Adjust CSS for inlinePies to be centered on the current line 2014-08-28 18:27:30 +02:00
Matthias Jentsch
a26370bb12 Adjust PieCharts that are rendered without labels 
Center and resize PieCharts to use the full width and height of the available view port
 2014-08-28 18:25:19 +02:00
Matthias Jentsch
00a2d225a2 Ensure that PieCharts are centered and that labels dont leave the viewBox 
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
 2014-08-28 16:42:31 +02:00
Matthias Jentsch
c5cface661 Improve readability of small pie charts 
Use a bigger font, to ensure that small pie charts still have readable labels.
 2014-08-28 16:40:34 +02:00
Matthias Jentsch
98809a1447 Do not use width and height as width and height percentages in the outer SVG element 
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
 2014-08-28 16:37:21 +02:00
Matthias Jentsch
a9eec0d672 Remove useless width and height properties from PieChart 2014-08-28 16:33:38 +02:00
Matthias Jentsch
f77cd9cafa Fix coding guidelines 2014-08-28 16:21:16 +02:00
Matthias Jentsch
573a4ea12f Fix spelling mistakes 2014-08-28 16:14:59 +02:00
Eric Lippmann
4ca1eaa7ce Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 
Conflicts:
	library/Icinga/Web/Form.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-28 13:58:02 +02:00
Marius Hein
e345aa257a Platform: Drop *Available function 
Create a function extensionLoaded and change usages.

refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein
9d0037a53a ResourceFactory: Add function create(<name>) 
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.

That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.

refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein
35d11bd145 Class doc for Platform 
refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein
9b83074cc9 Class doc for ResourceFactory 
refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein
22e17e9901 ResourceFactory: Move available function to platform 
refs #5514
 2014-08-28 12:14:54 +02:00
Matthias Jentsch
947cd0c5d3 Merge branch 'master' of git.icinga.org:icingaweb2 
fixes #7006
 2014-08-27 17:22:09 +02:00
Alexander Klimov
e6612fefe7 FilterParseException: extend IcingaException 
refs #6931
 2014-08-27 16:26:43 +02:00
Alexander Klimov
afd0c20c42 FilterException: extend IcingaException 
refs #6931
 2014-08-27 16:23:44 +02:00
Alexander Klimov
45638b218c Throw IcingaException rather than Exception 
fixes #7014
 2014-08-27 16:03:15 +02:00
Alexander Klimov
7ff51caed0 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 15:51:49 +02:00
Alexander Fuhr
236d384bab Fixes unaccepted behavior in module configuration 
fixes #7011
 2014-08-27 14:57:08 +02:00
Matthias Jentsch
4a59ff6712 Support preserveAspectRatio in SVGRenderer 
Add support for the preserveAspectRatio attributes in root SVG elements, to improve the handling of padding and automatic resizing of inline SVG.
 2014-08-27 13:51:52 +02:00
Johannes Meyer
e1329058db Do not hard code the name of the form identification element 
Like the csrf element name the form identification element name should
be publicly accessible as well.

refs #5525
 2014-08-27 13:14:40 +02:00
Eric Lippmann
1dea19504f Revert "Remove leading backslashes from the targets of use statements" 
This reverts commit 87a59675011a4cf284d8e44c4fb66042ad84c39f.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
 2014-08-27 12:24:11 +02:00
Marius Hein
88698cb05d Hook/TopBar: Rework interface for monitoring top bar 
refs #6929
 2014-08-27 11:31:48 +02:00
Marius Hein
b7ae66b496 Hook: Add web hook base class 
refs #6929
 2014-08-27 11:31:47 +02:00
Marius Hein
e0d7c3855d Hook: Add class suffix for base class testing 
refs #6928
 2014-08-27 11:31:47 +02:00
Alexander Klimov
87a5967501 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 11:16:44 +02:00
Marius Hein
5abf41edef Hook/ConfigurationTab: Remove deprecated implementation 
ConfigurationTab hook is not used anywhere. Test is
removed also.
 2014-08-27 10:29:04 +02:00
Johannes Meyer
6783d51f76 A form is "submitted" when it was "sent" but no submit label was set 
This enables us to use handleRequest() as is when no specific submit button
is required.

refs #5525
 2014-08-27 10:28:50 +02:00
Johannes Meyer
0ff79b0948 Replace Form::onFailure() with Form::onShow() 
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.

refs #5525
 2014-08-27 10:25:50 +02:00
Johannes Meyer
d3c2fc858c Access formdata internally using a public helper method 
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.

refs #5525
 2014-08-27 10:19:33 +02:00
Johannes Meyer
65dd3f9a5b Make the form in view scripts accessible using $form instead of $element 
refs #5525
 2014-08-27 10:10:55 +02:00
Johannes Meyer
98b2bce15e Icinga\Web\Form::onSuccess() must not return TRUE 
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.

refs #5525
 2014-08-27 10:09:29 +02:00
Marius Hein
89541f5727 Merge branch 'bugfix/hook-interface-6932' 
fixes #6932
fixes #6928
 2014-08-27 09:39:56 +02:00
Marius Hein
7e5b5a0b30 Hook/Grapher: Rework hook interface 
Rework interface based on specification and changed consumer calls.

refs #6932
 2014-08-27 09:35:43 +02:00
Matthias Jentsch
1ff63dbf3f Support nested keys expressed as single strings in the PreservingIniWriter 
Automatically convert keys with dots into nested configurations to avoid errors during the property diff, of the old and new configuration file.
 2014-08-26 18:05:22 +02:00
Eric Lippmann
6b88f1c98e Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module 
refs #6593
 2014-08-26 16:35:30 +02:00
Matthias Jentsch
ff1d2e4fed Fix coding style 2014-08-26 15:20:15 +02:00
Goran Rakic
23aa57a5d7 Remove 100% pie slice hack 
The getPieSlicePath primitive can draw it now.
 2014-08-26 15:20:15 +02:00
Goran Rakic
2575634dec Draw full circle pie slice (100%) as a primitive 
Allows getPieSlicePath to draw a full circle pie slice (100%) by slightly adjusting endpoint to have a valid arc. Also hides a central line as there will be no more pie slices.
 2014-08-26 15:20:15 +02:00
Marius Hein
376e9aa160 Rename hook base classes 
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes

refs #6928
 2014-08-26 14:29:55 +02:00
Johannes Meyer
45cbd3f067 We do not require the request being passed to handleRequest() 
refs #5525
 2014-08-26 12:31:05 +02:00
Johannes Meyer
5c7999fe9b Forms should be responsible for any redirection as well 
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.

refs #5525
 2014-08-26 12:30:37 +02:00
Alexander Klimov
1f7d4cb61b Merge branch 'master' into bugfix/exceptions-with-printf-params-6931 2014-08-26 11:24:33 +02:00
Alexander Klimov
a2011b1665 SystemPermissionException: extend IcingaException 
refs #6931
 2014-08-26 11:21:57 +02:00