4309 Commits

Author SHA1 Message Date
Sukhwinder Dhillon
a0ed272cb8 ApplicationBootstrap: Fix method name case 2023-08-23 10:53:14 +02:00
raviks789
c4a3cee94a UrlParams: Fix type for parameter $default of method get()
The parameter `default` can be null, string, int or bool.
2023-08-23 10:53:14 +02:00
raviks789
d6fd3a97ca DbRepository: Import exception QueryException 2023-08-23 10:53:14 +02:00
raviks789
c46446e17f Url: Fix type for parameter $value of method setParam() 2023-08-23 10:53:14 +02:00
raviks789
2a4f448c3e Url: Use Icinga\Web\Request instead of Zend_Request or Zend_Abstract_Request 2023-08-23 10:53:14 +02:00
raviks789
a317c5981f Discovery: Fix return type of the static method discover() 2023-08-23 10:53:14 +02:00
raviks789
4acee8ab06 Inspection: Fix return type of method error() 2023-08-23 10:53:14 +02:00
raviks789
e946ed1f0e UrlParams: Fix type for parameter $default of method getValues() 2023-08-23 10:53:14 +02:00
raviks789
d5e93a9d68 UrlParams: Fix type for parameter $value of method add()
The parameter `$value` can be null, string or bool.
2023-08-23 10:53:14 +02:00
raviks789
58938f6636 Config: Import exception NotWritableError 2023-08-23 10:53:13 +02:00
raviks789
1b9d977da4 Config: Fix parameter type for $fromDisk of method module() 2023-08-23 10:53:13 +02:00
raviks789
b585ed25df LdapUserGroupBackend: Update PHPDoc for method retrieveUserName() 2023-08-23 10:53:13 +02:00
raviks789
11c7f913c8 Benchmark: Define parameter $what as nullable 2023-08-23 10:53:13 +02:00
raviks789
dd8875f99f ConfigFormEventsHook: Use self to access static property $lastErrors 2023-08-23 10:53:13 +02:00
raviks789
2265b9d27b LegacyWeb: Import Exception class 2023-08-23 10:53:13 +02:00
raviks789
1c0480d484 Module: Use correct name case for Web::getFrontController() method 2023-08-23 10:53:13 +02:00
raviks789
381aee94d1 LdapUserBackend: Import exception QueryException
Method `LdapUserBackend::requireQueryColumn()` throws exception `QueryException`
2023-08-23 10:53:13 +02:00
raviks789
2b60a86731 Animation: Use correct name case for DOMElement::setAttribute() 2023-08-23 10:53:13 +02:00
raviks789
e1fd5c8500 PieSlice: Use correct name case for RenderContext::yToRelative() 2023-08-23 10:53:13 +02:00
raviks789
fb92c9b70a DbQuery: Import required class Zend_Db_Adapter_Abstract 2023-08-23 10:53:13 +02:00
raviks789
08e57939f2 TreeNodeIterator: Fix type for property $children 2023-08-23 10:53:13 +02:00
raviks789
e2ac5c9b08 Section: Fix type for property $commentPost 2023-08-23 10:53:13 +02:00
raviks789
ceead3dee2 LdapCapabilities: Use correct name case for generic class stdClass 2023-08-23 10:53:13 +02:00
raviks789
677a32545b DbRepository: Use correct name case for RepositoryQuery in joinColumn() method 2023-08-23 10:53:13 +02:00
raviks789
201706614d Repository: Return null if conversion rules is empty in getConverter()
In case the conversion rules to apply on the repository query is not defined
return null in `Repository::getConverter()`.
2023-08-23 10:53:13 +02:00
raviks789
aa5db51e77 Repository: Use correct name case for DateTime::getTimestamp() in retrieveGeneralizedTime() method 2023-08-23 10:53:13 +02:00
raviks789
22c790ea48 ActionControlle: Avoid void return in __call() magic method 2023-08-23 10:53:13 +02:00
raviks789
6b0244f247 ActionController: Declare property $view 2023-08-23 10:53:13 +02:00
raviks789
2db4e35b78 Button: Import class Zend_Config
The parameters for the constructor can be of type `Zend_Config`. Hence the class has been imported.
2023-08-23 10:53:13 +02:00
raviks789
f05d76e05e FormElement: Fix the return type of loadDefaultDecorators() 2023-08-23 10:53:13 +02:00
raviks789
4108b6b4cc Navigation: Cast string to int to perform addition
In `library/Icinga/Web/Navigation/Navigation::merge()` the result of `preg_match`
must be cast to int before adding 1 to it.
2023-08-23 10:53:13 +02:00
raviks789
fdddc21bc8 View: Define parameter $var for escape() as nullable 2023-08-23 10:53:13 +02:00
raviks789
bf5aa41d63 Widget: Imported class AbstractWidget
The return type of static method `Widget::create()` is `AbstractWidget` instance.
Hence it is imported in `Widget::class`.
2023-08-23 10:53:13 +02:00
raviks789
1d8ce55262 AbstractWidget: Import class Zend_View_Abstract
Since static property `AbstractWidget::view` is of type `Zend_View_Abstract` instance. The
class needs to be imported.
2023-08-23 10:53:13 +02:00
raviks789
daddfe11b5 Tab: Fix type of property $url
`$url` can either be a string or `Icinga\Web\Url` instance.
2023-08-23 10:53:13 +02:00
raviks789
3b707fb6ab Wizard: Fix return type for method getPage()
The method `Wizard::getPage()` could also return `ModulePage` instance. Hence it is included as one of the
return type of this method.
2023-08-23 10:53:13 +02:00
raviks789
bd0fb8c154 Remove the use of unavailable property $this->lessc->importDisabled
The functionality to set import to disabled is removed in `lessc`. Hence the code where this
property is used has been removed from `LessCompiler`.
2023-08-23 10:53:13 +02:00
raviks789
8e3c456327 Fix parameter name mismatch in View::escape method
The mismatch arises after migration from ZF1 to ZF-future.
2023-08-23 10:53:13 +02:00
raviks789
695fe25891 Remove dead code from Visitor.php
The method `Visitor::visitColor` seems like a dead code and contains dynamic property
allocation. Hence, this method has been removed.
2023-08-23 10:53:13 +02:00
raviks789
825f3a9b7f Avoid use of dynamic properties deprecated in PHP 8.2 2023-08-23 10:53:13 +02:00
Alexander A. Klimov
6de4bd6e7e Explicitly add Module#configdir as (non-dynamic) property
W/o this the login page, if on PHP 8.2, says:

Deprecated: Creation of dynamic property Icinga\Application\Modules\Module::$configdir is deprecated in /usr/share/icingaweb2/library/Icinga/Application/Modules/Module.php on line 264

This breaks modules (if any) which use the property and not the getter.
2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon
847ba4f395 PdfExport: Fix false positive ! empty($this->content) 2023-08-22 12:44:46 +02:00
raviks789
8b99852fc2
Remove unused FilterWidget::class (#5061) 2023-08-21 15:35:17 +02:00
Johannes Meyer
4a52a653e4 js: Always load redirects to their designated target
The server applies the redirection magic now, but only
for compatibility reasons.

resolves #4881
2023-08-11 16:08:00 +02:00
Johannes Meyer
65b3006adf Check if \Throwable instead of \Exception..
..everywhere else...

fixes #5079
2023-08-10 14:12:06 +02:00
Johannes Meyer
0a6db983f3 IcingaException: Expect \Throwable instead \Exception 2023-08-09 15:53:49 +02:00
raviks789
8a17c56345 Remove requiring vendor dependencies
Also avoid autoloading vendor.
2023-08-09 15:16:16 +02:00
raviks789
50bd5cfdc9 Remove librarary/vendor directory
The vendor dependencies will be moved to `composer.json` in `icinga-php-thirdparty`.
2023-08-09 15:16:16 +02:00
Johannes Meyer
597cb5c94d tests: Use a real app for bootstrapping
Makes the tests less isolated, but streamlines
the autoloading and other stuff in a way that's
more maintainable than before.
2023-07-05 09:24:49 +02:00
Johannes Meyer
82d39be642 BaseTestCase: Refactor request and response mocking 2023-07-04 17:05:06 +02:00