4309 Commits

Author SHA1 Message Date
Johannes Meyer
d452f3218d Use "ini" as preferences store in case preferences are not configured
refs #8234
2015-01-23 16:25:24 +01:00
Johannes Meyer
2a543bb5ae Rename the preference setting type' to store'
refs #8234
2015-01-23 16:25:23 +01:00
Eric Lippmann
7bd42b476f bootstrap: Load setup module in case the setup token exists
The web setup may write the config.ini even if it errors. Thus our bootstrap
has to load the setup module whenever the setup.token exists.
Another approach would to write the config.ini in our web setup at the very end.
2015-01-23 15:27:52 +01:00
Johannes Meyer
14a4aaeb77 Revert "Fix that when chosing to not to store preferences an invalid config is created"
This reverts commit 6284da451e2a3f1fecf8935f04701d889445203c.
2015-01-23 15:23:43 +01:00
Johannes Meyer
6284da451e Fix that when chosing to not to store preferences an invalid config is created
fixes #8234
2015-01-23 14:42:09 +01:00
Eric Lippmann
cd8822ceff lib: Add View::hasPermission() 2015-01-23 09:36:45 +01:00
Eric Lippmann
6da3cb8403 lib: Reorder auth related functions in the ActionController 2015-01-23 09:36:05 +01:00
Eric Lippmann
44de790cc9 Security: Temporary grant all permissions 2015-01-22 17:12:49 +01:00
Eric Lippmann
ef0a7c0e77 Revert "Security: Temporary grant all permissions"
This reverts commit 9b7e75a616e753e25cda033c86fab44e1281d7e9.

Patching function hasPermission is not enough. A fix will follow.
2015-01-22 17:11:53 +01:00
Eric Lippmann
0f13c0428c Controller: Introduce method assertHttpMethod()
We have actions where only certain HTTP methods, e.g. POST are allowed but they are not restricted yet.
Controller::assertHttpMethod() takes a number of allowed HTTP methods and responds with HTTP 405 in case
the current request's method is not one of the given methods.
2015-01-22 15:47:16 +01:00
Eric Lippmann
9b7e75a616 Security: Temporary grant all permissions
We'll introduce permissions and restrictions in the next hours. Because our web setup
does not configure permissions yet, all permissions are granted for all users from now on.
2015-01-22 15:20:38 +01:00
Eric Lippmann
f16aac5154 Security: Sort permissions only if not empty 2015-01-22 15:20:19 +01:00
Johannes Meyer
94d727dbb8 Fix error in Icinga\Web\Form in case the label decorator is missing
Zend_Form::getDecorator() returns false instead of null in case the
decorator is not found.
2015-01-22 09:21:50 +01:00
Johannes Meyer
10eacf9682 Allow jumping to already visited pages
This was already possible using just the base implementation of Wizard
but since WebWizard has optional pages it did not work with pages that
had such an optional page as previous page.

refs #8191
2015-01-21 15:39:06 +01:00
Johannes Meyer
64a8006973 Add Wizard::isComplete()
Wizard::isFinished() is not applicable in case a wizard is a child of another
wizard. Wizard::isComplete() fulfills the need to check whether a user went
through a wizard entirely.

refs #8191
2015-01-21 13:56:53 +01:00
Johannes Meyer
1f6a81aefb Add Wizard::skipPage()
Required to not to duplicate code in custom wizards and to avoid errors
when detecting the direction.

refs #8191
2015-01-21 13:07:08 +01:00
Johannes Meyer
2288e2a687 Add support for nested wizards
The amount of vertical dimensions is not limited as well as the location a
nested wizard can occur in the main wizard's order. In case a custom
implementation is used as nested wizard, all core functionalities are
still being utilized.

refs #8191
2015-01-20 15:54:14 +01:00
Eric Lippmann
2bd2f32b2e postgresql/auth: Fix that users cannot login when using PostgreSQL >= version 9.0
fixes #8251
2015-01-19 16:43:19 +01:00
Matthias Jentsch
4dfad963e9 Merge branch 'master' into feature/improve-chart-implementation-7841 2015-01-19 15:15:24 +01:00
Matthias Jentsch
ba1007465a Adapt bar width to amount of data points 2015-01-19 15:13:44 +01:00
Eric Lippmann
a1a36301fe View: Add string helpers 2015-01-19 14:20:57 +01:00
Eric Lippmann
a0a3241d1c lib: Add String::ellipsis() 2015-01-19 14:20:37 +01:00
Matthias Jentsch
fecd4151d1 Move axis labels to the top of the chart 2015-01-19 13:35:41 +01:00
Eric Lippmann
ac503031a7 Config: Fix PHPDoc for fromIni 2015-01-19 11:43:39 +01:00
Eric Lippmann
87adbacb3b Config: Fix coding style 2015-01-19 11:43:39 +01:00
Eric Lippmann
599cb620d8 Config: Don't throw NotReadableError if the file does not exist 2015-01-19 11:43:39 +01:00
Eric Lippmann
7fc70c5a02 IniWriter: Don't allow read for others on new files 2015-01-19 11:43:38 +01:00
Matthias Jentsch
f6eb9a764f Determine axis orientation based on max label length 2015-01-19 11:33:21 +01:00
Eric Lippmann
b983f1901b modules: Fix that the forms namespace is not registered when the module does not have any library file 2015-01-14 13:24:31 +01:00
Matthias Jentsch
76d3e5435f Display bigger legend labels correctly without overlapping 2015-01-13 18:25:19 +01:00
Matthias Jentsch
d1c7d9d2f9 Improve SVG layout 2015-01-13 18:21:11 +01:00
Matthias Jentsch
807666bf88 Improve chart axis readability
Introduce different line weights to separate between the smallest visible separator (steps) and single chart values (ticks). Calculate the amount of ticks per step using the available chart space.

fixes #7846
2015-01-13 17:56:50 +01:00
Matthias Jentsch
debc305789 Add logarithmic AxisUnit
resolves #7845
2015-01-13 17:56:50 +01:00
Eric Lippmann
fbe252063b IniWriter: Do not use umask(0)
chmod is not affected in any way by the umask.
2014-12-30 15:39:03 +01:00
Eric Lippmann
70c564bb0e Cli: Remove useless sprintf format in Command::fail() 2014-12-30 14:41:00 +01:00
Eric Lippmann
8eb37d9d76 Cli/Command: Add @type PHPDoc to params 2014-12-30 14:33:36 +01:00
Eric Lippmann
50bbf77d0c Fix module domain detection in Form::getTranslationDomain()
The usage of preg_replace had two errors:
1) The regular expression was wrong
2) $matches[0] always contains the full matched string, not the first parenthesized subpattern

The correct version of preg_replace would've been:

if (preg_match('/^Icinga\\\\Module\\\\([A-Za-z]+)\\\\/', get_called_class(), $matches) === 1) {
    return strtolower($matches[1]);
}

But since there's no benefit of using a regular expression here except less speed, I replaced it
with using explode.

refs #7551
2014-12-30 10:08:33 +01:00
Eric Lippmann
58cfb67983 Load setup module when necessary when bootstrapping the CLI
fixes #8146
2014-12-30 09:27:37 +01:00
Eric Lippmann
9d9dd8ac99 Merge branch 'feature/rhel-packages-6401'
resolves #6401
2014-12-29 16:50:20 +01:00
Eric Lippmann
57121bf0ea dompdf: Rename LICENSE.LGPL to LICENSE 2014-12-29 16:31:21 +01:00
Eric Lippmann
0b8ab18243 Parsedown: Rename LICENSE.txt to LICENSE 2014-12-29 16:30:44 +01:00
Matthias Jentsch
a1950aabba Fix some obsolete or wrong docstrings 2014-12-29 16:27:28 +01:00
Matthias Jentsch
4cf8da4bb9 Do not focus logout menu item after a recurring login
Implement new MenuItemRenderer made for pages that are not part
of the regular site navigation and should trigger a complete site reload
instead of handling it via XHR.
2014-12-29 16:20:05 +01:00
Eric Lippmann
839523a73f Web: Load setup module if necessary 2014-12-29 14:31:34 +01:00
Eric Lippmann
611d01788f Add setup related utility functions to ApplicationBootstrap.php 2014-12-29 14:29:31 +01:00
Eric Lippmann
7d36a59c67 Use '@return $this' instead of '@return self' for document fluent interfaces in ApplicationBootstrap.php 2014-12-29 14:01:19 +01:00
Eric Lippmann
4ea52161a9 Merge branch 'master' into feature/packages-4075 2014-12-29 12:31:38 +01:00
Boden Garman
5e40ce2088 Only check the session save path is writable if the session handler is 'files'
fixes #8053

Signed-off-by: Eric Lippmann <eric.lippmann@netways.de>
2014-12-29 09:37:47 +01:00
Eric Lippmann
7f5ba135ee Revert "Relax session storage check to the `files' save handler"
This reverts commit f7d11ce11f82b8e2716ed065ecdb0f4109ddd25a.

Sorry mate but a guy on GitHub was faster ;)

refs #8053
2014-12-29 09:37:07 +01:00
Matthias Jentsch
41c101d99f Use neutral default color in perfdata piecharts
If nothing is known about the state of the monitoring object, the piecharts should neither indicate OK nor Critical.
2014-12-23 16:12:25 +01:00