tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-05-23 16:10:11 +02:00
Code Issues Packages Projects Releases Wiki Activity
13,960 Commits 122 Branches 75 Tags
Commit Graph

4309 Commits

Author SHA1 Message Date
Johannes Meyer
e1329058db Do not hard code the name of the form identification element 
Like the csrf element name the form identification element name should
be publicly accessible as well.

refs #5525
 2014-08-27 13:14:40 +02:00
Eric Lippmann
1dea19504f Revert "Remove leading backslashes from the targets of use statements" 
This reverts commit 87a59675011a4cf284d8e44c4fb66042ad84c39f.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
 2014-08-27 12:24:11 +02:00
Marius Hein
88698cb05d Hook/TopBar: Rework interface for monitoring top bar 
refs #6929
 2014-08-27 11:31:48 +02:00
Marius Hein
b7ae66b496 Hook: Add web hook base class 
refs #6929
 2014-08-27 11:31:47 +02:00
Marius Hein
e0d7c3855d Hook: Add class suffix for base class testing 
refs #6928
 2014-08-27 11:31:47 +02:00
Alexander Klimov
87a5967501 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 11:16:44 +02:00
Marius Hein
5abf41edef Hook/ConfigurationTab: Remove deprecated implementation 
ConfigurationTab hook is not used anywhere. Test is
removed also.
 2014-08-27 10:29:04 +02:00
Johannes Meyer
6783d51f76 A form is "submitted" when it was "sent" but no submit label was set 
This enables us to use handleRequest() as is when no specific submit button
is required.

refs #5525
 2014-08-27 10:28:50 +02:00
Johannes Meyer
0ff79b0948 Replace Form::onFailure() with Form::onShow() 
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.

refs #5525
 2014-08-27 10:25:50 +02:00
Johannes Meyer
d3c2fc858c Access formdata internally using a public helper method 
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.

refs #5525
 2014-08-27 10:19:33 +02:00
Johannes Meyer
65dd3f9a5b Make the form in view scripts accessible using $form instead of $element 
refs #5525
 2014-08-27 10:10:55 +02:00
Johannes Meyer
98b2bce15e Icinga\Web\Form::onSuccess() must not return TRUE 
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.

refs #5525
 2014-08-27 10:09:29 +02:00
Marius Hein
89541f5727 Merge branch 'bugfix/hook-interface-6932' 
fixes #6932
fixes #6928
 2014-08-27 09:39:56 +02:00
Marius Hein
7e5b5a0b30 Hook/Grapher: Rework hook interface 
Rework interface based on specification and changed consumer calls.

refs #6932
 2014-08-27 09:35:43 +02:00
Matthias Jentsch
1ff63dbf3f Support nested keys expressed as single strings in the PreservingIniWriter 
Automatically convert keys with dots into nested configurations to avoid errors during the property diff, of the old and new configuration file.
 2014-08-26 18:05:22 +02:00
Eric Lippmann
6b88f1c98e Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module 
refs #6593
 2014-08-26 16:35:30 +02:00
Matthias Jentsch
ff1d2e4fed Fix coding style 2014-08-26 15:20:15 +02:00
Goran Rakic
23aa57a5d7 Remove 100% pie slice hack 
The getPieSlicePath primitive can draw it now.
 2014-08-26 15:20:15 +02:00
Goran Rakic
2575634dec Draw full circle pie slice (100%) as a primitive 
Allows getPieSlicePath to draw a full circle pie slice (100%) by slightly adjusting endpoint to have a valid arc. Also hides a central line as there will be no more pie slices.
 2014-08-26 15:20:15 +02:00
Marius Hein
376e9aa160 Rename hook base classes 
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes

refs #6928
 2014-08-26 14:29:55 +02:00
Johannes Meyer
45cbd3f067 We do not require the request being passed to handleRequest() 
refs #5525
 2014-08-26 12:31:05 +02:00
Johannes Meyer
5c7999fe9b Forms should be responsible for any redirection as well 
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.

refs #5525
 2014-08-26 12:30:37 +02:00
Alexander Klimov
1f7d4cb61b Merge branch 'master' into bugfix/exceptions-with-printf-params-6931 2014-08-26 11:24:33 +02:00
Alexander Klimov
a2011b1665 SystemPermissionException: extend IcingaException 
refs #6931
 2014-08-26 11:21:57 +02:00
Alexander Klimov
febb2d1ae2 ProgrammingError: extend IcingaException 
refs #6931
 2014-08-26 11:15:19 +02:00
Alexander Fuhr
d8bbd7a0a0 Merge branch 'bugfix/modules-dashlet-provider-6639' 
fixes #6639
 2014-08-26 10:57:37 +02:00
Alexander Klimov
4ec6dbe3f0 Prefer single quotes ' rather than double quotes " 2014-08-26 10:41:17 +02:00
Alexander Fuhr
42e2b34356 Implement self provided configuration for dashboard/dashlets in modules 
refs #6639
 2014-08-26 10:34:36 +02:00
Alexander Klimov
f754531e4d Fix grammatical error 2014-08-26 10:22:14 +02:00
Johannes Meyer
52534a2f46 It is a form's responsibility to process the request it was submitted with 
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)

refs #5525
 2014-08-25 17:06:45 +02:00
Johannes Meyer
c93ab7951d Check whether a form's data was sent instead of whether it's complete 
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.

refs #5525
 2014-08-25 16:49:54 +02:00
Alexander Klimov
7074fa1331 NotWritableError: extend IcingaException 
refs #6931
 2014-08-25 12:56:35 +02:00
Alexander Klimov
6c9947326d NotReadableError: extend IcingaException 
refs #6931
 2014-08-25 12:38:34 +02:00
Alexander Klimov
f4dbb4df96 NotImplementedError: extend IcingaException 
refs #6931
 2014-08-25 12:21:59 +02:00
Alexander Klimov
013aad8f73 MissingParameterException: extend IcingaException 
refs #6931
 2014-08-25 12:14:18 +02:00
Johannes Meyer
7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer
2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Alexander Klimov
9c5878cbbe ConfigurationError: extend IcingaException 
refs #6931
 2014-08-22 11:46:11 +02:00
Alexander Fuhr
20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr
1886569174 Implement Module self provided configuration for menus 
refs #6639
 2014-08-22 11:35:42 +02:00
Johannes Meyer
bc05d2ee64 Merge LoggingForm into GeneralForm 
fixes #6933
 2014-08-22 11:05:20 +02:00
Alexander Klimov
b764993091 AuthenticationException: extend IcingaException 
refs #6931
 2014-08-22 10:59:52 +02:00
Alexander Klimov
b55a313146 Implement IcingaException 
refs #6931
 2014-08-22 10:27:30 +02:00
Thomas Gelf
09412d03b6 Benchmark: hide timestamp on HTML output 
Wastes space and is mostly useless, absolut and relative expired time
gives more than enough information.
 2014-08-22 09:34:43 +02:00
Alexander Klimov
8733238a6e Loader::registerNamespace(): correct exception message 2014-08-21 12:40:41 +02:00
Johannes Meyer
bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
 2014-08-20 13:13:50 +02:00
Eric Lippmann
995355ec30 lib/Limiter: fix translate w/ sprintf 2014-08-19 16:29:11 +02:00
Thomas Gelf
f49a34625e Url\Params: check for QUERY_STRING before using it 
fixes #6957
 2014-08-19 14:53:56 +02:00
Eric Lippmann
1c74fd7028 Merge branch 'master' into feature/display-documentation-4820 
Conflicts:
	modules/doc/library/Doc/DocParser.php
 2014-08-19 13:39:48 +02:00
Thomas Gelf
db3ef8fbd0 ActionController: remove redirectToLogin default 
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
 2014-08-19 12:28:24 +02:00