4097 Commits

Author SHA1 Message Date
Eric Lippmann
0b1d2bf685 Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 2014-09-02 17:09:36 +02:00
Eric Lippmann
5485ca8a25 lib: Use Zend's Int' validator in the Number' form element
Further disabled default decorators since our form sets them.

refs #5525
2014-09-02 16:54:43 +02:00
Thomas Gelf
b60b811335 ApplicationBootstrap: list "core" translations
Just to make application fit module capabilities. We might find a better
place for both later on.

refs #7054
2014-09-02 16:51:17 +02:00
Johannes Meyer
95c839a8bd Remove remaining usages of the ElementWrapper- and HelpText-Decorator
refs #5525
2014-09-02 16:50:59 +02:00
Thomas Gelf
6faedf5733 ActionController: no benchmark for no renderer
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
Thomas Gelf
4cef333add Modules\Module: implement listLocales
fixes #7054
2014-09-02 16:28:27 +02:00
Thomas Gelf
e4687a60f9 Web\JavaScript: use Cache and ETags
refs #6927
2014-09-02 16:25:44 +02:00
Johannes Meyer
1ba3df310c Remove BaseConfigController, User\Message and Widget\AlertMesageBox
refs #6758
2014-09-02 16:25:03 +02:00
Johannes Meyer
539ab91ffa Add the FormErrors decorator as default decorator for forms
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.

refs #5525
2014-09-02 16:25:03 +02:00
Thomas Gelf
f0d6cf994e Web\StyleSheet: use Cache and ETags 2014-09-02 16:24:55 +02:00
Thomas Gelf
ff6483cec5 Web\FileCache: initial implementation
refs #6927
2014-09-02 16:22:48 +02:00
Johannes Meyer
338f549233 Add class ReadablePathValidator 2014-09-02 16:19:45 +02:00
Johannes Meyer
39bb01b433 Rename Icinga\Web\Form::onShow() to onRequest()
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525
2014-09-02 16:19:45 +02:00
Eric Lippmann
9bcd861b1c Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 2014-09-02 15:27:27 +02:00
Eric Lippmann
d4c4ab7b2c lib/form: Fix default element decorators but breaking noscript layout
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.

Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.

refs #5525
2014-09-02 15:23:07 +02:00
Eric Lippmann
8478ef3fce lib: Remove `HelpText' form element decorator
Zend already has a `Description' decorator.

refs #5525
2014-09-02 15:05:47 +02:00
Eric Lippmann
7143837ae3 lib: Remove `ElementWrapper' form element decorator
Zend has a `Label' decorator already.

refs #5525
2014-09-02 15:04:23 +02:00
Thomas Gelf
62c0f0be03 Web\Session: implement lazy loading
fixes #7055
2014-09-02 13:23:15 +02:00
Alexander Fuhr
26339b128a Add disabled property and implement the functionality
refs #6986
2014-09-02 13:16:21 +02:00
Matthias Jentsch
4b55bcf8b6 Add tooltips to bar charts
Add a class to format and populate tooltips from graph data sets and implement
those tooltips in the ChartController.
2014-09-02 12:24:29 +02:00
Alexander Fuhr
bb0e1dc105 Revert "Fixes unaccepted behavior in module configuration"
This reverts commit 236d384bab3c1b64f3fd9954487accc33aafe48a.
2014-09-02 10:23:41 +02:00
Marius Hein
ee6145a173 Ldap/Query: Remove __toString()
This is needed because of exception handling. Exceptions can now bubble
up for default handling. Method render() was renamed to create() because
the method create a query. Adjust the test for method create().

refs #5536
2014-09-02 10:17:01 +02:00
Marius Hein
baf768040f LdapQuery: Use Ldap/Exception for errors
refs #5536
2014-09-02 09:55:57 +02:00
Marius Hein
6b6826f737 Bug7043Test: Fix test to run without ini configuration
fixes #7043
2014-09-01 15:53:32 +02:00
Johannes Meyer
cd8015f41a Pass the current form instance to the callback as second argument
refs #5525
2014-09-01 14:58:16 +02:00
Eric Lippmann
30965c247b Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593 2014-09-01 14:50:32 +02:00
Eric Lippmann
0822aff293 library/form: Fix return value of `getName()' not being filterd the first time it's called
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.

refs #5525
2014-09-01 14:40:45 +02:00
Marius Hein
30f391035c Postgres/DbQuery: Add orderfields to select
refs #6896
2014-09-01 10:00:04 +02:00
Eric Lippmann
f3e74f0f24 library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
Before, the class attribute would've been overwritten.

refs #5525
2014-09-01 09:44:04 +02:00
Eric Lippmann
a01ee00c27 Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
Conflicts:
	library/Icinga/Protocol/Commandpipe/Transport/Transport.php
2014-08-29 17:24:44 +02:00
Johannes Meyer
fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
Johannes Meyer
e020dd3541 Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath
Prior to this change it was not possible to create an instance of Config
without passing a config file.
2014-08-29 12:23:48 +02:00
Johannes Meyer
79b0ed64ec Make it possible to provide a closure to be called instead of onSuccess()
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.

refs #5525
2014-08-29 12:21:31 +02:00
Johannes Meyer
bf23688e73 Make autosubmit work in non-JS enviroments
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.

refs #5525
2014-08-29 09:08:53 +02:00
Johannes Meyer
486104d59e Check explictly for FALSE when calling onSuccess()
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.

refs #5525
2014-08-29 09:04:20 +02:00
Matthias Jentsch
3642b7b6fc Adjust CSS for inlinePies to be centered on the current line 2014-08-28 18:27:30 +02:00
Matthias Jentsch
a26370bb12 Adjust PieCharts that are rendered without labels
Center and resize PieCharts to use the full width and height of the available view port
2014-08-28 18:25:19 +02:00
Matthias Jentsch
00a2d225a2 Ensure that PieCharts are centered and that labels dont leave the viewBox
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
2014-08-28 16:42:31 +02:00
Matthias Jentsch
c5cface661 Improve readability of small pie charts
Use a bigger font, to ensure that small pie charts still have readable labels.
2014-08-28 16:40:34 +02:00
Matthias Jentsch
98809a1447 Do not use width and height as width and height percentages in the outer SVG element
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
2014-08-28 16:37:21 +02:00
Matthias Jentsch
a9eec0d672 Remove useless width and height properties from PieChart 2014-08-28 16:33:38 +02:00
Matthias Jentsch
f77cd9cafa Fix coding guidelines 2014-08-28 16:21:16 +02:00
Matthias Jentsch
573a4ea12f Fix spelling mistakes 2014-08-28 16:14:59 +02:00
Eric Lippmann
4ca1eaa7ce Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
Conflicts:
	library/Icinga/Web/Form.php
	modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-28 13:58:02 +02:00
Marius Hein
e345aa257a Platform: Drop *Available function
Create a function extensionLoaded and change usages.

refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein
9d0037a53a ResourceFactory: Add function create(<name>)
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.

That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.

refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
35d11bd145 Class doc for Platform
refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
9b83074cc9 Class doc for ResourceFactory
refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
22e17e9901 ResourceFactory: Move available function to platform
refs #5514
2014-08-28 12:14:54 +02:00
Matthias Jentsch
947cd0c5d3 Merge branch 'master' of git.icinga.org:icingaweb2
fixes #7006
2014-08-27 17:22:09 +02:00