tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-05-02 22:00:15 +02:00
Code Issues Packages Projects Releases Wiki Activity
13,656 Commits 127 Branches 75 Tags
Commit Graph

4097 Commits

Author SHA1 Message Date
Johannes Meyer
8da37e5ca2
Merge pull request #4044 from Icinga/fix/pdf-export-error-handling 
Fix pdf export error handling
 2020-01-14 11:13:01 +01:00
Johannes Meyer
6a8f17faf2 OutputFormat: Just provide the pdf export if there's a hook available 
Calling `isSupported()` is bad here since there may be IO involved.
 2020-01-14 11:01:53 +01:00
Johannes Meyer
29aaa363b4 Pdf: Utilize an pdfexport hook without calling isSupported() 
If it's not supported, users should disable the module. If there
are multiple hooks supported at some point we need to touch this
again anyways. So that should suffice for now.
 2020-01-14 10:59:01 +01:00
Johannes Meyer
9fe43dda5f ActionController: Drop method handlerBrowserWindows() 2020-01-14 10:14:02 +01:00
Johannes Meyer
855bb8ae72 Properly handle window id's and container id's 2020-01-14 10:14:02 +01:00
Johannes Meyer
2d3fc218db Window: Differentiate between window and container id 2020-01-14 10:14:02 +01:00
Johannes Meyer
d459e58aca Response: Add methods to override the client's window id 2020-01-14 10:14:02 +01:00
Johannes Meyer
098bcfb98f LdapConnection: Ignore unknown vendor upon inspection 2020-01-13 13:46:32 +01:00
Johannes Meyer
7bb9c8e25f LdapConnnection: Don't pass param $serverCtrls to ldap_search prior php 7.3 
refs #4013
 2020-01-13 13:17:40 +01:00
Johannes Meyer
5a58279995 ActionController: Don't render exceptions as PDF 2020-01-10 14:11:52 +01:00
Johannes Meyer
5943e6bde9 Pdf: Restore previous state after rendering content 
In case an exception occurs its output was previously merged
with the rendered content or even PDF..
 2020-01-10 14:11:40 +01:00
Johannes Meyer
f63dfa5294 DbUserBackend: Use binary string comparison if it's a mysql db 2019-12-11 10:15:05 +01:00
Johannes Meyer
e6d9819adb FilterQueryString: Parse numbers as floats in range conditions 2019-12-09 09:39:50 +01:00
Johannes Meyer
dc8981f209 ConfigFormEventsHook: Use base class Icinga\Web\Form in type hints 2019-12-09 09:01:33 +01:00
Johannes Meyer
4157821c89 IcingaCheckbox: Don't display:none the checkbox but add .sr-only to it 2019-12-05 16:12:41 +01:00
Johannes Meyer
668ae38497 ExternalBackend: Don't authenticate a user if REMOTE_USER is empty 2019-12-05 15:13:02 +01:00
Johannes Meyer
d0857345d0 DbConnection: Set COLLATE 'latin1_general_ci' for latin1 charsets 
MySQL 8+ seems a bit more strict now.
 2019-12-05 14:18:17 +01:00
Johannes Meyer
8519bb5d11 User: Don't return true if any permission is granted and * is required 2019-12-05 08:44:33 +01:00
Johannes Meyer
7b488d7f93 swag: Fix violations of PSR-12 
PSR-2 has been deprecated and phpcs v3.5.3
now checks for the successor PSR-12
 2019-12-04 11:28:08 +01:00
Johannes Meyer
0442c4f0ab View: Ignore setting short_open_tag 
Adjusting class `Zend_View_Stream` according to https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.stream-wrappers
didn't work. (*syntax error, unexpected end of file* after every last php statement in phtml files)

So.. since `<?= ?>` instructions are permanently available since PHP 5.4 (https://www.php.net/manual/en/language.basic-syntax.phptags.php)
we'll just omit using a custom stream wrapper now.
 2019-12-04 09:35:24 +01:00
Johannes Meyer
7bc1893a24 LdapConnection: Don't utilize ldap_control_paged_result() on PHP 7.3+ 
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.ldap
 2019-12-04 09:33:13 +01:00
Johannes Meyer
9b1dc44130 FilterEditor: Also trim trailing whitespace from search values 
Simple values are wrapped with `*` anyway, so trimming all
whitespace doesn't pose an issue. (Even if inserted intentionally)
This doesn't apply to qualified search values. (e.g. `host = abc `)

resolves #4002
 2019-12-03 10:33:00 +01:00
Eric Lippmann
9f4e29b56c JS/CSS: Load modal behavior and styles 2019-11-04 12:46:30 +01:00
Eric Lippmann
c196631f5a Add Markdown::line() 2019-10-31 14:41:39 +01:00
Johannes Meyer
e0be21f655 Raise version to 2.7.3 2019-10-18 07:41:53 +02:00
Johannes Meyer
362c30c1dd Raise version to 2.7.2 2019-10-16 08:12:09 +02:00
Johannes Meyer
8e5380220c SimpleQuery: Cache count query result and use it in hasResult() 
Does not affect views which do not run a count query. (e.g. dashlets)
Though, this is a quick win for all other views with which the user
interacts directly and gets the desired result quicker than before.

refs #3905
refs #3836
 2019-10-11 10:27:43 +02:00
Johannes Meyer
52d830170f LessCompiler: Put required assets into a module's css block 
We have to include these there otherwise mixins from assets
can't be used.
 2019-10-01 15:30:17 +02:00
Johannes Meyer
5352e72d1f
Merge pull request #3946 from Icinga/fix/wrong-dashlet-order-3931 
Fix wrong dashlet order
 2019-09-26 14:34:13 +02:00
Johannes Meyer
d699191629
Let modules provide css/js assets to be used by other modules (#3961) 2019-09-25 09:53:53 +02:00
Johannes Meyer
f98f988aff Remove tristate form element 2019-09-23 08:36:24 +02:00
Johannes Meyer
d4dc282ac8 DashboardContainer: Allow to define a priority for dashlets 
refs #3931
 2019-09-09 14:43:28 +02:00
Johannes Meyer
04b23811be Raise version to 2.7.1 2019-08-14 13:10:19 +02:00
Eric Lippmann
c8ed889114 Fix operator in wildcard filter chains 2019-08-13 17:19:45 +02:00
Eric Lippmann
31d3153d2b Support wildcard filters in chains (#3903) 2019-08-12 13:41:38 +02:00
Eric Lippmann
666bdfb4c4 Revert "Fix double query execution" 
This reverts PR 6ea012af7e0fe409ecbff2b1e455d237a5f44d69, reversing
changes made to be5b9f870b5124df4516dfac39383810efec6899.

The reverted commit fixed a double query execution bug by only executing
the query once in either SimpleQuery::hasResult() or upon iteration.

But the fix (b20291a60) introduced two problems:

* Default sort rules no longer work
* Show more links missing

We work with DataView objects in our controllers and views. When
iterating over a DataView, it applies its default sort rules and then
returns the underlying query, see DataView::getIterator().

DataView::hasResult() on the other hand does not apply the default sort
rules. So, if hasResult() is called first, the default sort rules are no
longer applied because the query will be executed only once.
The fix would be as easy as to apply sorting in DataView::hasResult() as
well.

But now the show more part kicks in. We know whether there are more
results because we execute queries with $limit + 1. This is enabled via
SimpleQuery::peekAhead(). Unfortunately, we call
SimpleQuery::peekAhead() ALWAYS after SimpleQuery::hasResult(). And
that's why the show more links are missing because the query is executed
only once with the "wrong" limit.

For now, we just revert the commit in question and postpone a proper fix
for the double execution.
 2019-08-07 13:29:57 +02:00
Eric Lippmann
f35946df29 Raise version to 2.7.0 2019-07-30 10:19:53 +02:00
Eric Lippmann
b8fb193bdd Add FilterChain::setFilters() 2019-07-30 09:17:25 +02:00
Johannes Meyer
9cdf37410c ApplicationStateMessages: Fix message layout 2019-07-29 10:19:39 +02:00
Johannes Meyer
13ad506393 css: Rename class icinga-forms to icinga-form 2019-07-29 10:17:59 +02:00
Johannes Meyer
212606de78 setup: Apply new icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer
0bc70a840c SortBox: Apply icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer
346083109a Apply new form style to the filter editor 2019-07-29 10:17:59 +02:00
Johannes Meyer
05613c413d Enhance toggle-switch, spinner and control-info placement 
tested with Chromium, IE11 (Win7), Edge (Win10)
 2019-07-29 10:17:59 +02:00
Johannes Meyer
115bb80c6a View: Register our own view helper path 
That's a different path than application/views/helpers because this one
uses a namespace so that we're able to extend Zend's view helpers
 2019-07-29 10:17:59 +02:00
Johannes Meyer
bc2e7588d7 FormNotifications: Don't ignore warning and error notifications 2019-07-29 10:17:59 +02:00
Johannes Meyer
a5f292c2ae Form: Define classes icinga-forms and icinga-controls by default 2019-07-29 10:17:59 +02:00
Florian Strohmaier
f14256a7ee CSS: Adapt form design with filter editor 
refs #3676
 2019-07-29 10:17:59 +02:00
Florian Strohmaier
f70f996085 Announcements: Increase font-size and align control layout 
refs #3676
refs #3560
refs #3839
 2019-07-29 10:17:59 +02:00
Florian Strohmaier
c492c6bb23 Announcements: Avoid duplicate `id attribute 
refs #3762
 2019-07-29 10:17:59 +02:00