14137 Commits

Author SHA1 Message Date
Eric Lippmann
0bac6cfe07 Config: Add setting to enable strict CSP 2023-08-24 16:02:06 +02:00
Johannes Meyer
6c68578a6c
Github Actions: Add PhpStan (#5040)
Blocked by: #5061 
closes #5052, https://github.com/Icinga/icingaweb2/pull/4920,
https://github.com/Icinga/icingaweb2/pull/5003
2023-08-23 11:53:21 +02:00
Sukhwinder Dhillon
2818757bc6 phpstan: Ignore LdapCapabilities/LdapConnection errors
- ldap_connect() returns `LDAP\Connection` in php >= 81
2023-08-23 11:37:00 +02:00
Sukhwinder Dhillon
fe24d7809f Phpstan: Set level to max and add baseline file
- Remove already default flags in `max` level
- Don't ingnore Zend_* errors explicitly (added to baseline)
2023-08-23 11:37:00 +02:00
Sukhwinder Dhillon
3f3f0a1f67 GlobFilter::__construct(): Add possible param type hint 2023-08-23 11:37:00 +02:00
Sukhwinder Dhillon
0cf97d5825 Workflow: clone the remote head, regardless of the branch name 2023-08-23 11:36:30 +02:00
raviks789
9887a2d622 ConfigTest: Define property $oldConfigDir
Use of dynamic property is deprecated since PHP 8.2
2023-08-23 10:53:15 +02:00
Yonas Habteab
a82e3b2320 Stylable: Fix strokeWidth type hint declaration 2023-08-23 10:53:15 +02:00
Yonas Habteab
55b4a5eb63 StaticController: Pass only strings to str_pad as first argument 2023-08-23 10:53:15 +02:00
Yonas Habteab
a965b5c44b Fix argument type hints 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
ffe84507f9 Host/Servie::getDataView(): Fix return class name case 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
2fa9aaedb0 (Host/Service)status: Fix class name case 2023-08-23 10:53:15 +02:00
raviks789
19151763af UrlParams: Fix parameter types of addValues() method 2023-08-23 10:53:15 +02:00
raviks789
eed1b0a680 Url: Fix type of parameter $values of with() method 2023-08-23 10:53:15 +02:00
raviks789
6353f79528 VersionCommand: Avoid using deprecated ${} string interpolation 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
fd984c5798 Loader: Fix Variable '$obj' is probably undefined 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
17c2a19e28 ObjectList: Pass the correct value to unset()
- $featureStatus is an associative array
2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
e3ce1c4b2d (Hosts/Services)Controller: Cannot check ObjectList instance with ! empty() 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
5d5b767afe Setup Module (finish.phtml): Add empty array if $report is null 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
6f04c54f3c ListController::createTabs(): Add missing return statement 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
907486ccac NavigationItemRenderer::setOptions(): Add missing return statement 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
66c4fc404e LocalFileStorage::create(): Add missing return statement 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
ee9d139a3a PhpDoc: Fix incorrect @param and @return type hints 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon
8d55385e38 HealthController: Add return statement in new line because render() returns nothing 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
63556849c9 HostnotificationQuery: Fix Variable '$$concattedContacts' is probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
8960324fcd ResourceStep: Fix Variable '$dbHtml, $ldapHtml' are probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
e5981ed2b5 GeneralConfigStep: Fix Variable '$typeDescription, $typeSpecificHtml' are probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
07e272f3cc RequirementsRenderer: Add $tags explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
8cfc40affe RequirementSet: Fix sprintf args 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
b755650256 Requirement: Fix exception throw 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
dae38414f8 AuthBackendPage: Fix Variable '$backendForm' is probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
01352cf6c2 AdminAccountPage: Fix Variable '$groups, $users' are probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
d1bfde0dc5 ConfigCommand: Fix Variable '$webserver' is probably undefined and import missing Exception class 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
7adc25ba38 TimeRange: Fix class name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
0901e841a3 PerfData: Fix method name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
92c647e883 CustomVarRendererHook: Remove unused param $object 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
84589f8833 BackendStep: Fix Variable '$$resourceTitle, $resourceHtml' is probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
c1bdec65f4 ServicenotificationQuery: Fix Variable '$$concattedContacts' is probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
9f3a9a006e IdoQuery: Fix method name case and var name type 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
edb9500805 EventgridQuery: Remove duplicate array entry 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
be060edd9f AllcontactsQuery: Add $baseQuery explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
7cd89490cc (EventOverview/StateHistory)Form: Method getValue() expects only one param 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
4341a32c1f ProcessCheckResultCommandForm: Fix Variable '$object' is probably undefined 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
3db461ed62 ListController: Fix method name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
9d5bf610eb ModuleController: Fix typo in global var name 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
5e671e02af Wizard: Fix throw exception 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
302bf3ef54 Tabs: Add $tab_class explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
30b91b9cd2 Tabs: Method render() does not expect any param and import missing Exception class 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
29b2ed22b9 AbstractWidget: Method render() does not expect any param 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon
e2e582b095 Navigation/-Item: Fix Variable '$classPath' is probably undefined 2023-08-23 10:53:14 +02:00