Commit Graph

144 Commits

Author SHA1 Message Date
Markus Frosch c3ef50978a style: Fix minor styleguide issues for PHPCS 2017-11-08 10:06:45 +01:00
Michael Friedrich 2c312adf94 API Commands: Only send acknowledgement expire time if not null
Icinga 2 v2.7.0 is more strict with the `expiry` attribute if sent
(cannot be null, or in the past).

While acknowledgments with expire time worked well (and do so with this patch),
the command renderer did not check whether the value is actually not null
before setting it into the data form. The boolean value from the checkbox is
not available in the command renderer unfortunately.

@lippserd: Verified working with and without expire time inside the Vagrant boxes.

fixes #2911
2017-08-08 12:53:39 +02:00
Eric Lippmann 7a2d8eda8d Fix exception when the response from the Icinga 2 API has an empty result set
fixes #2805
2017-04-04 09:17:52 +02:00
Alexander A. Klimov 96e7411e25 TransportConfigForm: validate whether the Icinga 2 API can be connected to
refs #2674
2017-02-13 14:56:35 +01:00
Alexander A. Klimov 96ef0dccf8 Make JSON error handling logic reusable
refs #2728
2017-02-09 19:50:04 +01:00
Alexander A. Klimov 6fbec7134c Handle invalid Icinga 2 API response types
refs #2728
2017-02-09 13:38:43 +01:00
Eric Lippmann cde55b5764 Support failover API command transport configuration
fixes #13957
2017-01-12 10:39:36 +01:00
Eric Lippmann 4f6c54e62c Support scheduling a downtime for all services of a host w/ the Icinga 2 API as command transport
fixes #12810
2016-12-08 10:40:22 +01:00
Eric Lippmann 93474972bf Enable propagate host downtime commands for Icinga 2
This only works when using the latest Icinga 2 snapshot packages. Before releasing Web 2.4.0, we have to include a check to only offer these commands when using Icinga 2 2.6.0+

refs #10774
2016-11-08 15:27:29 +01:00
Eric Lippmann 440a3f5fdd Respect API transport in the command transport factory
refs #11398
2016-09-01 10:49:08 +02:00
Eric Lippmann db41024c89 Add ApiCommandTransport class
refs #11398
2016-09-01 10:47:27 +02:00
Eric Lippmann ad658b049c Add IcingaApiCommandRenderer class
refs #11398
2016-09-01 10:45:28 +02:00
Eric Lippmann 0f4fa2d492 Add IcingaApiCommand class
refs #11398
2016-09-01 10:44:59 +02:00
Eric Lippmann 62f2f92ae8 Add name property to the delete downtime command
refs #11398
2016-08-31 15:21:27 +02:00
Eric Lippmann b8df909ad5 Add name property to the delete comment command
refs #11398
2016-08-31 15:06:38 +02:00
Eric Lippmann 1bbe1b3620 RemoteCommandFile: Don't close stdin to support transmitting multiple commands 2016-06-09 16:43:06 +02:00
Thomas Gelf 3a00923116 RemoteCommandFile: Replace exec with proc_open 2016-06-06 15:08:45 +02:00
Eric Lippmann c834e66b9a Show useful error message if a command transport failed
fixes #10173
2016-02-25 10:36:10 +01:00
Alexander A. Klimov 474803fee4 Change all license headers to only reflect a file's year of creation
refs #11000
2016-02-08 15:41:00 +01:00
Eric Lippmann 0f8c28d749 Merge branch 'master' into feature/api-9606 2015-09-07 11:33:44 +02:00
Johannes Meyer b7cdfcfae0 CommandTransport: Respect instance association
refs #9651
2015-08-31 12:19:42 +02:00
Johannes Meyer 1d6d4f0b10 RemoteCommandFile: Accept option `instance'
refs #9651
2015-08-31 12:19:00 +02:00
Johannes Meyer 04ef3f1244 LocalCommandFile: Accept option `instance'
refs #9651
2015-08-31 12:18:25 +02:00
Johannes Meyer fcbd24e28e CommandTransport: Add fallback mechanism
refs #8981
refs #9651
2015-08-31 09:21:59 +02:00
Johannes Meyer 6651d31481 CommandTransport: Use commandtransports as config file name
refs #9651
2015-08-26 14:17:23 +02:00
Eric Lippmann f722e242fd monitoring: Optimize method order in the DeleteCommentCommand 2015-08-21 10:33:18 +02:00
Eric Lippmann fbb16e5ea2 monitoring: Optimize method order in the DeleteDowntimeCommand 2015-08-21 10:30:41 +02:00
Eric Lippmann cb0b3c8754 monitoring: Let PHP flush the writer buffer to the command file
refs #9570
2015-08-10 11:31:27 +02:00
Eric Lippmann 919c7c52cf monitoring: Fix PHPDoc in DeleteDowntimeCommand 2015-07-28 13:33:56 +02:00
Eric Lippmann dd7d078704 monitoring: Fix PHPDoc in DeleteCommentCommand 2015-07-28 13:33:56 +02:00
Eric Lippmann 901e6754eb monitoring: Define CommandTransportInterface::send() 2015-07-28 12:32:19 +02:00
Eric Lippmann b2fb0a836f monitoring: Move CommandTransportException to the monitoring's exception namespace 2015-07-28 12:32:19 +02:00
Eric Lippmann 4536eacd66 monitoring: Rename TransportException to CommandTransportException 2015-07-28 12:32:19 +02:00
Matthias Jentsch 42de13a2b9 Merge branch 'feature/ssh-remote-connection-resource-configuration-7595'
resolves #7595
2015-06-15 17:30:42 +02:00
Johannes Meyer cd0c418854 Merge branch 'master' into feature/user-and-group-management-8826 2015-06-02 10:44:13 +02:00
Eric Lippmann 9f155ea99d monitoring: Don't show SSH command when transporting a command to a remote command file failed
refs #8006
2015-05-28 16:33:35 +02:00
Eric Lippmann a4a1a296d1 monitoring: Reduce error output when transporting a command to a local command file failed
refs #8006
2015-05-28 16:13:35 +02:00
Alexander Fuhr 49589128ef Rename identity_key with private_key in ssh resource
refs #7595
2015-05-28 14:09:13 +02:00
Alexander Fuhr a47d05a038 Add identity key usage for a specific user in remote command
refs #7595
fixes #7447
2015-05-28 10:51:56 +02:00
Johannes Meyer 59ff4221f6 CommandTransport: Make sure to reset the config before calling current() 2015-05-22 14:01:11 +02:00
Matthias Jentsch ffd12e325c Improve up downtime command form properties
Use a flag instead of a enumeration in delete downtime command form, to remove needless boilerplate.

refs #8624
2015-05-07 14:05:16 +02:00
Matthias Jentsch b35dd4ddfe Separate forms for deleting single and multiple comments
refs #8624
2015-05-07 14:03:09 +02:00
Matthias Jentsch 6ddb004230 Move removal command actions into the downtime controllers
refs #8902
2015-05-07 10:34:06 +02:00
Eric Lippmann 9d4460d02f Use inheritdoc in the ScheduleServiceCheckCommand 2015-04-15 14:59:29 +02:00
Eric Lippmann b8849c0ac9 Return $this in the setters of the SendCustomNotificationCommand
Further fixed bad PHPDoc.
2015-04-15 14:59:29 +02:00
Alexander Klimov 967a2e82dc Use (only) "@return $this" in fluent interfaces' documentation 2015-04-07 14:24:11 +02:00
Eric Lippmann 06d9e4113c Fix that sending multiple commands over SSH failed
The config object has to cloned before unsetting the transport because else the
transport is removed for all subsequent calls to CommandTransport::fromConfig().

fixes #8815
2015-04-01 13:53:44 +02:00
Eric Lippmann 32487e4e21 Ignore settings from instances.ini that don't have a setter on the transport class used
fixes #8543
2015-03-13 03:41:33 +01:00
Marius Hein df3d81e181 SendCustomNotificationCommand: Update phpdoc strings
refs #8644
2015-03-12 16:30:11 +01:00
Marius Hein ddc8dd5d4c Add command send custom notification to monitoring module
refs #8644
2015-03-12 16:08:22 +01:00